Skip to content

Fix Test on PR GitHub Pytest CI not running #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobleesj opened this issue Nov 7, 2024 · 2 comments · Fixed by #159
Closed

Fix Test on PR GitHub Pytest CI not running #157

bobleesj opened this issue Nov 7, 2024 · 2 comments · Fixed by #159

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Nov 7, 2024

Problem

Proposed solution

Investigate and leave a comment below
@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 7, 2024

Solution

Error message:

Invalid workflow file: .github/workflows/tests-on-pr.yml#L12
The workflow is not valid. .github/workflows/tests-on-pr.yml (Line: 12, Col: 11): Secret CODECOV_TOKEN is required, but not provided while calling.

We need to provide codecov secret for the tests-on-pr.yml (new cookiecutting standard)

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 7, 2024

I will fix it.

@bobleesj bobleesj mentioned this issue Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Codecov secret to .github/workflows/tests-on-pr.yml to use Codecov bobleesj/diffpy.utils
1 participant
@bobleesj