Skip to content

differaction objects improve functions q_to_tth, tth_to_q #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yucongalicechen opened this issue Nov 14, 2024 · 1 comment · Fixed by #178
Closed

differaction objects improve functions q_to_tth, tth_to_q #174

yucongalicechen opened this issue Nov 14, 2024 · 1 comment · Fixed by #178

Comments

@yucongalicechen
Copy link
Contributor

Problem

Functions do not handle invalid cases (when tth > 180 or arcsin value > 1).

Proposed solution

Raise valueerror for those cases. Refer to #154 for more details.

@sbillinge
Copy link
Contributor

I am guessing this won't be a ValueError. We can have it crash the way it does now (invalid arcsin) but we want to overload the error message to help the user know how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants