Skip to content

Remove set_angles_from_list, set_angles_from, set_qs_from_range and tests associated #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobleesj opened this issue Dec 14, 2024 · 0 comments · Fixed by #233
Closed

Remove set_angles_from_list, set_angles_from, set_qs_from_range and tests associated #232

bobleesj opened this issue Dec 14, 2024 · 0 comments · Fixed by #233

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Dec 14, 2024 •
edited
Loading

@sbillinge Can I remove these util functions from the package? Since @yucongalicechen has started writing docs and docstrings, thought it would be best to keep it as portable as possible. But, I have copied and pasted those test functions explicitly above.

Originally posted by @bobleesj in #198 (comment)

Remove the functions provided in the issue attached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove set_angles_from_list, set_angles_from, set_qs_from_range bobleesj/diffpy.utils
1 participant
@bobleesj