Skip to content

fix XQUANTITIES in docstring #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #143
yucongalicechen opened this issue Dec 18, 2024 · 6 comments
Closed
Tracked by #143

fix XQUANTITIES in docstring #247

yucongalicechen opened this issue Dec 18, 2024 · 6 comments
Assignees

Comments

@yucongalicechen
Copy link
Contributor

          @bobleesj in the docstring the XQUANTITIES is not showing. Shall I open a new issue or just comment on #239?

4
5

Originally posted by @yucongalicechen in #246 (comment)

@yucongalicechen yucongalicechen self-assigned this Dec 18, 2024
@bobleesj
Copy link
Contributor

@yucongalicechen do you mind addressing this one? I am away from keyboard till Thursday evening

@yucongalicechen
Copy link
Contributor Author

@yucongalicechen do you mind addressing this one? I am away from keyboard till Thursday evening

No prob, I already self-assigned this haha

@sbillinge
Copy link
Contributor

I left a comment on #246 . This may not fix, and that may be ok. I would rather keep this as a dynamic unpack and have it not build right in the API docs than move it to an explicitly typed list that is harder to maintain.

@bobleesj
Copy link
Contributor

If it works sth like,

Must be one of "x, y, z" defined in XQUANTITY.

Where x y z ... are dynamically rendered.

Hitting 2 birds (user, dev facing) at once?

@sbillinge
Copy link
Contributor

I would just leave it tbh. In danger of just making it worse here

@yucongalicechen
Copy link
Contributor Author

I was thinking about something similar to @bobleesj 's comment. @sbillinge shall i close this issue or move it to 3.7.0 release then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants