Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revisit tests for DO operations #298

Closed
yucongalicechen opened this issue Dec 30, 2024 · 1 comment · Fixed by #299
Closed

fix: revisit tests for DO operations #298

yucongalicechen opened this issue Dec 30, 2024 · 1 comment · Fixed by #299

Comments

@yucongalicechen
Copy link
Contributor 

          is the condition "same length xarray" or "on the same `q/tth/d-array`"?  I think it should be the latter or we are adding things incorrectly.  Please can you check the code.  If the code is doing it right, change the doc.  If hte doc is right, we probably should revisit hte tests and code.

Originally posted by @sbillinge in #297 (comment)
@yucongalicechen yucongalicechen mentioned this issue Dec 30, 2024
Merged
@bobleesj
Copy link
Contributor

bobleesj commented Dec 30, 2024 •
edited
Loading

Could you check the _check_operation? Thats how the code checks for the shape modified by @sbillinge

@bobleesj bobleesj mentioned this issue Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bobleesj @yucongalicechen