Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown atom or ion symbol error #33

Open
Tieqiong opened this issue Aug 13, 2024 · 0 comments
Open

Unknown atom or ion symbol error #33

Tieqiong opened this issue Aug 13, 2024 · 0 comments

Comments

@Tieqiong
Copy link
Contributor

Tieqiong commented Aug 13, 2024

Description
When calculating PDF from ICSD .cif files, there exists ~70k files that would raise ValueError: Unknown atom or ion symbol.

To Reproduce
Take icsd_000001.cif as example. First load the file and create a structure instance using diffpy.structure, then try calculating the PDF by calling diffpy.srreal.pdfcalculator.PDFCalculator. It will raise ValueError: Unknown atom or ion symbol 'Te4+'..

Traceback
The error is raised in findWKFormula function in libdiffpy. With further investigation this error occurs when the ion (atom bare symbol with atom valence) is not in the file f0_WaasKirf.dat. The file was created in 2002 (the link inside is outdated) but I found the most recent version of it on ESRF Anonymous FTP Server. The new version can't solve the issue though, as there's still no data of ions such as Te4+.

Guessing
We might need to add new items in the existing file, or write functions to convert missing ion to existing entries.

Also see diffpy/diffpy.srreal#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant