Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Loading style to match RN activity indicator style #3087

Open
steffenkleinle opened this issue Feb 13, 2025 · 0 comments
Open

Adjust Loading style to match RN activity indicator style #3087

steffenkleinle opened this issue Feb 13, 2025 · 0 comments
Labels
Native Affects the native project ready Task

Comments

@steffenkleinle
Copy link
Member

steffenkleinle commented Feb 13, 2025

Describe the Problem

At the moment, we use different components to indicate that some progress is happening:

  1. ProgressSpinner.tsx: Custom full screen component including a spinner around the integreat logo (primarily used in LoadingErrorHandler)
  2. RefreshControl: React native component used in scroll views/list views if actual content is displayed (primarily used in LoadingErrorHandler)
  3. LoadingSpinner.tsx: Based on react native ActivityIndicator component, for example used when sending feedback

While the progress spinner (1.) is distinct and required, the refresh control (2.) and the loading spinner (3.) are used similarly and also look/behave similarly(but not the same. We should therefore unify the styling.
Personally I like the default style of the refresh control a lot more,

Describe Your Preferred Solution

Adjust the styling of the LoadingSpinner such that it looks the same as the refresh control:

  • Change the spinner color to black
  • Add an elevated white circle around it

Furthermore, adjust the naming of our different loading spinner components such that the purpose is clear:

  1. ProgressSpinner -> LoadingScreen
  2. RefreshControl -> RefreshControl (no change, this is a react native component)
  3. LoadingSpinner -> base/ActivityIndicator (move to base folder)

Describe Possible Alternatives

Adjust the style of the refresh control or just keep it as it is.

Related Issues

N/A

Additional Information

To see the ProgressSpinner (1.): Select a new city
To see the RefreshControl (2.): Just pull down to refresh on any page
To see the LoadingSpinner (3.): Send a feedback (or change

if (sendingStatus === 'sending') {
to if (true) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Native Affects the native project ready Task
Projects
Status: No status
Development

No branches or pull requests

1 participant