tests(examples): do not use anymore default aws vpc

Previously, example tests assumed the presence of a
default AWS VPC in every account, which led to intermittent
failures when that VPC was deleted, disabled, or locked down
with restrictive security rules.

This commit create full aws network stack for each examples.

Author: diodonfrost

examples/autoscaling-scheduler-terminate-instances/main.tf

@@ -17,15 +17,6 @@ data "aws_ami" "ubuntu" {
   owners = ["099720109477"] # Canonical
 }
 
-resource "aws_vpc" "this" {
-  cidr_block = "10.0.0.0/16"
-}
-
-resource "aws_subnet" "this" {
-  vpc_id     = aws_vpc.this.id
-  cidr_block = "10.0.1.0/24"
-}
-
 resource "aws_launch_template" "this" {
   name_prefix   = "web_config"
   image_id      = data.aws_ami.ubuntu.id

examples/autoscaling-scheduler-terminate-instances/vpc.tf

@@ -0,0 +1,8 @@
+resource "aws_vpc" "this" {
+  cidr_block = "10.0.0.0/16"
+}
+
+resource "aws_subnet" "this" {
+  vpc_id     = aws_vpc.this.id
+  cidr_block = "10.0.1.0/24"
+}

examples/autoscaling-scheduler/main.tf

@@ -17,15 +17,6 @@ data "aws_ami" "ubuntu" {
   owners = ["099720109477"] # Canonical
 }
 
-resource "aws_vpc" "this" {
-  cidr_block = "10.0.0.0/16"
-}
-
-resource "aws_subnet" "this" {
-  vpc_id     = aws_vpc.this.id
-  cidr_block = "10.0.1.0/24"
-}
-
 resource "aws_launch_template" "this" {
   name_prefix   = "web_config"
   image_id      = data.aws_ami.ubuntu.id

examples/autoscaling-scheduler/terraform.tftest.hcl

@@ -33,7 +33,7 @@ run "create_test_infrastructure" {
   }
 
   assert {
-    condition     = module.test-execution.asg_instance_scheduled_state == "stopped"
+    condition     = module.test-execution.asg_instance_scheduled_state == "stopped" || module.test-execution.asg_instance_scheduled_state == "stopping"
     error_message = "Autoscaling group instance should be stopped"
   }
 

examples/autoscaling-scheduler/vpc.tf

@@ -0,0 +1,8 @@
+resource "aws_vpc" "this" {
+  cidr_block = "10.0.0.0/16"
+}
+
+resource "aws_subnet" "this" {
+  vpc_id     = aws_vpc.this.id
+  cidr_block = "10.0.1.0/24"
+}

examples/ecs-scheduler/cloudwatch_alarm.tf

@@ -9,7 +9,7 @@ resource "aws_cloudwatch_metric_alarm" "service_count" {
   threshold           = "2"
   alarm_description   = "Less than 2 Running Service on cluster"
   dimensions = {
-    ClusterName = aws_ecs_cluster.hello.id
+    ClusterName = aws_ecs_cluster.this.id
   }
 
   tags = {

examples/ecs-scheduler/ecs.tf

@@ -1,16 +1,16 @@
-resource "aws_ecs_cluster" "hello" {
-  name = "ecs-scheduler-test-cluster"
+resource "aws_ecs_cluster" "this" {
+  name = "test-ecs-cluster-${random_pet.suffix.id}"
 
   setting {
     name  = "containerInsights"
     value = "disabled"
   }
 }
 
-resource "aws_ecs_service" "hello" {
+resource "aws_ecs_service" "to_scheduled" {
   name            = "test-to-stop-${random_pet.suffix.id}"
-  cluster         = aws_ecs_cluster.hello.id
-  task_definition = aws_ecs_task_definition.hello.arn
+  cluster         = aws_ecs_cluster.this.id
+  task_definition = aws_ecs_task_definition.this.arn
   desired_count   = 1
   launch_type     = "FARGATE"
 
@@ -29,10 +29,10 @@ resource "aws_ecs_service" "hello" {
   }
 }
 
-resource "aws_ecs_service" "hello-false" {
+resource "aws_ecs_service" "not_to_scheduled" {
   name            = "test-not-to-stop-${random_pet.suffix.id}"
-  cluster         = aws_ecs_cluster.hello.id
-  task_definition = aws_ecs_task_definition.hello.arn
+  cluster         = aws_ecs_cluster.this.id
+  task_definition = aws_ecs_task_definition.this.arn
   desired_count   = 1
   launch_type     = "FARGATE"
 
@@ -51,8 +51,8 @@ resource "aws_ecs_service" "hello-false" {
   }
 }
 
-resource "aws_ecs_task_definition" "hello" {
-  family = "test--${random_pet.suffix.id}"
+resource "aws_ecs_task_definition" "this" {
+  family = "test-${random_pet.suffix.id}"
 
   # Refer to https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-cpu-memory-error.html
   # for cpu and memory values
@@ -68,8 +68,17 @@ resource "aws_ecs_task_definition" "hello" {
   container_definitions = jsonencode([
     {
       name      = "hello-world-rest"
-      image     = "public.ecr.aws/docker/library/busybox:latest"
+      image     = "docker.io/library/nginx:alpine"
+      cpu       = 10
+      memory    = 128
       essential = true
+      portMappings = [
+        {
+          containerPort = 80
+          hostPort      = 80
+          protocol      = "tcp"
+        }
+      ]
     }
   ])
-}
+}

examples/instance-scheduler/main.tf

@@ -17,19 +17,23 @@ data "aws_ami" "ubuntu" {
 }
 
 resource "aws_instance" "scheduled" {
-  count         = "3"
-  ami           = data.aws_ami.ubuntu.id
-  instance_type = "t2.micro"
+  count                  = "3"
+  ami                    = data.aws_ami.ubuntu.id
+  instance_type          = "t2.micro"
+  subnet_id              = aws_subnet.public.id
+  vpc_security_group_ids = [aws_security_group.instance.id]
   tags = {
     tostop = "true"
     Name   = "ec2-to-scheduled-${random_pet.suffix.id}-${count.index}"
   }
 }
 
 resource "aws_instance" "not_scheduled" {
-  count         = "2"
-  ami           = data.aws_ami.ubuntu.id
-  instance_type = "t2.micro"
+  count                  = "2"
+  ami                    = data.aws_ami.ubuntu.id
+  instance_type          = "t2.micro"
+  subnet_id              = aws_subnet.public.id
+  vpc_security_group_ids = [aws_security_group.instance.id]
   tags = {
     tostop = "false"
     Name   = "ec2-not-to-scheduled-${random_pet.suffix.id}-${count.index}"

examples/instance-scheduler/terraform.tftest.hcl

@@ -12,17 +12,17 @@ run "create_test_infrastructure" {
   }
 
   assert {
-    condition     = module.test-execution.instance_1_scheduled_state == "stopped"
+    condition     = module.test-execution.instance_1_scheduled_state == "stopped" || module.test-execution.instance_1_scheduled_state == "stopping"
     error_message = "Virtual machine 1 to stop is not stopped"
   }
 
   assert {
-    condition     = module.test-execution.instance_2_scheduled_state == "stopped"
+    condition     = module.test-execution.instance_2_scheduled_state == "stopped" || module.test-execution.instance_2_scheduled_state == "stopping"
     error_message = "Virtual machine 2 to stop is not stopped"
   }
 
   assert {
-    condition     = module.test-execution.instance_3_scheduled_state == "stopped"
+    condition     = module.test-execution.instance_3_scheduled_state == "stopped" || module.test-execution.instance_3_scheduled_state == "stopping"
     error_message = "Virtual machine 3 to stop is not stopped"
   }
 

examples/instance-scheduler/test-execution/main.tf

@@ -13,38 +13,38 @@ resource "aws_lambda_invocation" "this" {
   depends_on = [time_sleep.before_stop_wait_30_seconds]
 }
 
-resource "time_sleep" "after_stop_wait_60_seconds" {
-  create_duration = "60s"
+resource "time_sleep" "after_stop_wait_30_seconds" {
+  create_duration = "30s"
 
   depends_on = [aws_lambda_invocation.this]
 }
 
 data "aws_instance" "instance_1_to_scheduled_id" {
   instance_id = var.instance_1_to_scheduled_id
 
-  depends_on = [time_sleep.after_stop_wait_60_seconds]
+  depends_on = [time_sleep.after_stop_wait_30_seconds]
 }
 
 data "aws_instance" "instance_2_to_scheduled_id" {
   instance_id = var.instance_2_to_scheduled_id
 
-  depends_on = [time_sleep.after_stop_wait_60_seconds]
+  depends_on = [time_sleep.after_stop_wait_30_seconds]
 }
 
 data "aws_instance" "instance_3_to_scheduled_id" {
   instance_id = var.instance_3_to_scheduled_id
 
-  depends_on = [time_sleep.after_stop_wait_60_seconds]
+  depends_on = [time_sleep.after_stop_wait_30_seconds]
 }
 
 data "aws_instance" "instance_1_not_to_scheduled_id" {
   instance_id = var.instance_1_not_to_scheduled_id
 
-  depends_on = [time_sleep.after_stop_wait_60_seconds]
+  depends_on = [time_sleep.after_stop_wait_30_seconds]
 }
 
 data "aws_instance" "instance_2_not_to_scheduled_id" {
   instance_id = var.instance_2_not_to_scheduled_id
 
-  depends_on = [time_sleep.after_stop_wait_60_seconds]
+  depends_on = [time_sleep.after_stop_wait_30_seconds]
 }

examples/instance-scheduler/vpc.tf

@@ -0,0 +1,50 @@
+resource "aws_vpc" "main" {
+  cidr_block           = "10.0.0.0/16"
+  enable_dns_hostnames = true
+  enable_dns_support   = true
+}
+
+resource "aws_subnet" "public" {
+  vpc_id                  = aws_vpc.main.id
+  cidr_block              = "10.0.1.0/24"
+  map_public_ip_on_launch = true
+  availability_zone       = "${data.aws_region.current.name}a"
+}
+
+resource "aws_internet_gateway" "main" {
+  vpc_id = aws_vpc.main.id
+}
+
+resource "aws_route_table" "public" {
+  vpc_id = aws_vpc.main.id
+
+  route {
+    cidr_block = "0.0.0.0/0"
+    gateway_id = aws_internet_gateway.main.id
+  }
+}
+
+resource "aws_route_table_association" "public" {
+  subnet_id      = aws_subnet.public.id
+  route_table_id = aws_route_table.public.id
+}
+
+resource "aws_security_group" "instance" {
+  name        = "scheduler-test-instance-sg"
+  description = "Security group for test instances"
+  vpc_id      = aws_vpc.main.id
+
+  ingress {
+    from_port   = 22
+    to_port     = 22
+    protocol    = "tcp"
+    cidr_blocks = ["0.0.0.0/0"]
+  }
+
+  egress {
+    from_port   = 0
+    to_port     = 0
+    protocol    = "-1"
+    cidr_blocks = ["0.0.0.0/0"]
+  }
+}

examples/rds-scheduler/main.tf

@@ -1,30 +1,6 @@
 # Terraform rds with lambda scheduler
 resource "random_pet" "suffix" {}
 
-# Get aws availability zones
-data "aws_availability_zones" "available" {}
-
-resource "aws_vpc" "this" {
-  cidr_block = "10.103.0.0/16"
-}
-
-resource "aws_subnet" "primary" {
-  availability_zone = data.aws_availability_zones.available.names[0]
-  vpc_id            = aws_vpc.this.id
-  cidr_block        = "10.103.98.0/24"
-}
-
-resource "aws_subnet" "secondary" {
-  availability_zone = data.aws_availability_zones.available.names[1]
-  vpc_id            = aws_vpc.this.id
-  cidr_block        = "10.103.99.0/24"
-}
-
-resource "aws_db_subnet_group" "aurora" {
-  name       = "aurora-subnet-${random_pet.suffix.id}"
-  subnet_ids = [aws_subnet.primary.id, aws_subnet.secondary.id]
-}
-
 resource "aws_rds_cluster" "aurora_scheduled" {
   cluster_identifier   = "test-to-stop-aurora-cluster-${random_pet.suffix.id}"
   engine               = "aurora-mysql"

examples/rds-scheduler/vpc.tf

@@ -0,0 +1,22 @@
+data "aws_availability_zones" "available" {}
+
+resource "aws_vpc" "this" {
+  cidr_block = "10.103.0.0/16"
+}
+
+resource "aws_subnet" "primary" {
+  availability_zone = data.aws_availability_zones.available.names[0]
+  vpc_id            = aws_vpc.this.id
+  cidr_block        = "10.103.98.0/24"
+}
+
+resource "aws_subnet" "secondary" {
+  availability_zone = data.aws_availability_zones.available.names[1]
+  vpc_id            = aws_vpc.this.id
+  cidr_block        = "10.103.99.0/24"
+}
+
+resource "aws_db_subnet_group" "aurora" {
+  name       = "aurora-subnet-${random_pet.suffix.id}"
+  subnet_ids = [aws_subnet.primary.id, aws_subnet.secondary.id]
+}