Improve refactorability in tests.

Author: iclanton

apps/rush-lib/src/api/test/ChangeFile.test.ts

@@ -7,7 +7,7 @@ import { ChangeFile } from '../ChangeFile';
 import { RushConfiguration } from '../RushConfiguration';
 import { ChangeType } from '../ChangeManagement';
 
-describe('ChangeFile', () => {
+describe(ChangeFile.name, () => {
   it('can add a change', () => {
     const rushFilename: string = path.resolve(__dirname, 'repo', 'rush-npm.json');
     const rushConfiguration: RushConfiguration = RushConfiguration.loadFromConfigurationFile(rushFilename);

apps/rush-lib/src/api/test/CommonVersionsConfiguration.test.ts

@@ -5,7 +5,7 @@ import * as path from 'path';
 
 import { CommonVersionsConfiguration } from '../CommonVersionsConfiguration';
 
-describe('CommonVersionsConfiguration', () => {
+describe(CommonVersionsConfiguration.name, () => {
   it('can load the file', () => {
     const filename: string = path.resolve(__dirname, 'jsonFiles', 'common-versions.json');
     const configuration: CommonVersionsConfiguration = CommonVersionsConfiguration.loadFromFile(filename);

apps/rush-lib/src/api/test/EnvironmentConfiguration.test.ts

@@ -4,7 +4,7 @@
 import * as path from 'path';
 import { EnvironmentConfiguration } from '../EnvironmentConfiguration';
 
-describe('EnvironmentConfiguration', () => {
+describe(EnvironmentConfiguration.name, () => {
   let _oldEnv: typeof process.env;
 
   beforeEach(() => {
@@ -17,7 +17,7 @@ describe('EnvironmentConfiguration', () => {
     process.env = _oldEnv;
   });
 
-  describe('validate', () => {
+  describe(EnvironmentConfiguration.validate.name, () => {
     it('correctly allows no environment variables', () => {
       expect(EnvironmentConfiguration.validate).not.toThrow();
     });

apps/rush-lib/src/api/test/EventHooks.test.ts

@@ -5,7 +5,7 @@ import * as path from 'path';
 import { RushConfiguration } from '../RushConfiguration';
 import { Event, EventHooks } from '../EventHooks';
 
-describe('EventHooks', () => {
+describe(EventHooks.name, () => {
   it('loads a post build hook from rush.json', () => {
     const rushFilename: string = path.resolve(__dirname, 'repo', 'rush-npm.json');
     const rushConfiguration: RushConfiguration = RushConfiguration.loadFromConfigurationFile(rushFilename);

apps/rush-lib/src/api/test/LastInstallFlag.test.ts

@@ -2,13 +2,13 @@
 // See LICENSE in the project root for license information.
 
 import * as path from 'path';
+import { FileSystem } from '@rushstack/node-core-library';
 
 import { LastInstallFlag } from '../LastInstallFlag';
-import { FileSystem } from '@rushstack/node-core-library';
 
 const TEMP_DIR: string = path.join(__dirname, 'temp');
 
-describe('LastInstallFlag', () => {
+describe(LastInstallFlag.name, () => {
   beforeEach(() => {
     FileSystem.ensureEmptyFolder(TEMP_DIR);
   });

apps/rush-lib/src/api/test/RushConfiguration.test.ts

@@ -19,7 +19,7 @@ function assertPathProperty(validatedPropertyName: string, absolutePath: string,
   expect(normalizePathForComparison(absolutePath)).toEqual(normalizePathForComparison(resolvedRelativePath));
 }
 
-describe('RushConfiguration', () => {
+describe(RushConfiguration.name, () => {
   let _oldEnv: typeof process.env;
 
   beforeEach(() => {

apps/rush-lib/src/api/test/VersionMismatchFinder.test.ts

@@ -12,7 +12,7 @@ import { VersionMismatchFinderProject } from '../../logic/versionMismatch/Versio
 import { VersionMismatchFinderCommonVersions } from '../../logic/versionMismatch/VersionMismatchFinderCommonVersions';
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
-describe('VersionMismatchFinder', () => {
+describe(VersionMismatchFinder.name, () => {
   it('finds no mismatches if there are none', () => {
     const projectA: VersionMismatchFinderEntity = new VersionMismatchFinderProject({
       packageName: 'A',

apps/rush-lib/src/api/test/VersionPolicy.test.ts

@@ -7,8 +7,8 @@ import { IPackageJson } from '@rushstack/node-core-library';
 import { VersionPolicyConfiguration } from '../VersionPolicyConfiguration';
 import { VersionPolicy, LockStepVersionPolicy, IndividualVersionPolicy, BumpType } from '../VersionPolicy';
 
-describe('VersionPolicy', () => {
-  describe('LockStepVersion', () => {
+describe(VersionPolicy.name, () => {
+  describe(LockStepVersionPolicy.name, () => {
     const filename: string = path.resolve(__dirname, 'jsonFiles', 'rushWithLockVersion.json');
     const versionPolicyConfig: VersionPolicyConfiguration = new VersionPolicyConfiguration(filename);
     let versionPolicy1: VersionPolicy;
@@ -116,7 +116,7 @@ describe('VersionPolicy', () => {
     });
   });
 
-  describe('IndividualVersionPolicy', () => {
+  describe(IndividualVersionPolicy.name, () => {
     const fileName: string = path.resolve(__dirname, 'jsonFiles', 'rushWithIndividualVersion.json');
     const versionPolicyConfig: VersionPolicyConfiguration = new VersionPolicyConfiguration(fileName);
     const versionPolicy: VersionPolicy = versionPolicyConfig.getVersionPolicy('testPolicy2');

apps/rush-lib/src/cli/actions/test/AddAction.test.ts

@@ -7,8 +7,9 @@ import * as path from 'path';
 
 import { PackageJsonUpdater } from '../../../logic/PackageJsonUpdater';
 import { RushCommandLineParser } from '../../RushCommandLineParser';
+import { AddAction } from '../AddAction';
 
-describe('AddAction', () => {
+describe(AddAction.name, () => {
   describe(`basic "rush add" tests`, () => {
     let doRushAddMock: jest.SpyInstance;
     let oldExitCode: number | undefined;

apps/rush-lib/src/cli/test/RushCommandLineParser.test.ts

@@ -82,8 +82,8 @@ function getCommandLineParserInstance(repoName: string, taskName: string): IPars
 const SPAWN_ARG_ARGS: number = 1;
 const SPAWN_ARG_OPTIONS: number = 2;
 
-describe('RushCommandLineParser', () => {
-  describe('execute', () => {
+describe(RushCommandLineParser.name, () => {
+  describe(RushCommandLineParser.prototype.execute.name, () => {
     afterEach(() => {
       jest.clearAllMocks();
     });