fix: based on code review

Author: g-chao

build-tests-subspace/rush-lib-test/package.json

@@ -11,8 +11,7 @@
   },
   "dependencies": {
     "@microsoft/rush-lib": "workspace:*",
-    "@rushstack/terminal": "workspace:*",
-    "colors": "~1.2.1"
+    "@rushstack/terminal": "workspace:*"
   },
   "devDependencies": {
     "@rushstack/heft": "workspace:*",

build-tests-subspace/rush-sdk-test/config/heft.json

@@ -11,6 +11,12 @@
           "taskPlugin": {
             "pluginPackage": "@rushstack/heft-typescript-plugin"
           }
+        },
+        "lint": {
+          "taskDependencies": ["typescript"],
+          "taskPlugin": {
+            "pluginPackage": "@rushstack/heft-lint-plugin"
+          }
         }
       }
     }

build-tests-subspace/rush-sdk-test/package.json

@@ -10,11 +10,11 @@
     "_phase:build": "heft run --only build -- --clean"
   },
   "dependencies": {
-    "@rushstack/rush-sdk": "workspace:*",
-    "colors": "~1.2.1"
+    "@rushstack/rush-sdk": "workspace:*"
   },
   "devDependencies": {
     "@rushstack/heft": "workspace:*",
+    "@rushstack/heft-lint-plugin": "workspace:*",
     "@rushstack/heft-typescript-plugin": "workspace:*",
     "@microsoft/rush-lib": "workspace:*",
     "@types/node": "18.17.15",
@@ -30,6 +30,9 @@
     "@rushstack/heft": {
       "injected": true
     },
+    "@rushstack/heft-lint-plugin": {
+      "injected": true
+    },
     "@rushstack/heft-typescript-plugin": {
       "injected": true
     }

common/config/rush/browser-approved-packages.json

@@ -54,10 +54,6 @@
       "name": "axios",
       "allowedCategories": [ "libraries" ]
     },
-    {
-      "name": "colors",
-      "allowedCategories": [ "tests" ]
-    },
     {
       "name": "dependency-path",
       "allowedCategories": [ "libraries" ]
@@ -90,10 +86,6 @@
       "name": "redux",
       "allowedCategories": [ "libraries", "vscode-extensions" ]
     },
-    {
-      "name": "rimraf",
-      "allowedCategories": [ "tests" ]
-    },
     {
       "name": "rxjs",
       "allowedCategories": [ "libraries" ]

common/config/rush/pnpm-lock.yaml

@@ -16,7 +16,7 @@
    * path segment in the "$schema" field for all your Rush config files.  This will ensure
    * correct error-underlining and tab-completion for editors such as VS Code.
    */
-  "rushVersion": "5.115.0",
+  "rushVersion": "5.116.0",
 
   /**
    * The next field selects which package manager should be installed and determines its version.