DEV: Update linting config and run gjs-codemod (#85)

Author: CvX

.discourse-compatibility

@@ -1,3 +1,4 @@
+< 3.5.0.beta5-dev: f92eab97a15556df502ea4d644920071b8446e09
 < 3.5.0.beta1-dev: 7c56ad642017bd7649f531cab57d2da0f6d4f84d
 < 3.4.0.beta2-dev: 9b5d5b16aa800d8d43dfe3f871594bf68f69cf02
 < 3.4.0.beta1-dev: 7dff8ccbcda763519cc1b94806b701af56875c3d

Gemfile.lock

@@ -15,41 +15,41 @@ GEM
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
-    drb (2.2.1)
+    connection_pool (2.5.3)
+    drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
     minitest (5.25.5)
-    parallel (1.26.3)
-    parser (3.3.7.3)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
     prism (1.4.0)
     racc (1.8.1)
-    rack (3.1.12)
+    rack (3.1.16)
     rainbow (3.1.1)
     regexp_parser (2.10.0)
-    rubocop (1.75.1)
+    rubocop (1.76.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.43.0, < 2.0)
+      rubocop-ast (>= 1.45.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.43.0)
+    rubocop-ast (1.45.0)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-capybara (2.22.1)
@@ -67,13 +67,13 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.30.3)
+    rubocop-rails (2.32.0)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.6.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -100,4 +100,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.6.6
+   2.6.9

javascripts/discourse/components/modal/ucd-warning.js renamed to javascripts/discourse/components/modal/ucd-warning.gjs

@@ -3,9 +3,11 @@ import { action } from "@ember/object";
 import { service } from "@ember/service";
 import { htmlSafe } from "@ember/template";
 import { escape } from "pretty-text/sanitizer";
+import DModal from "discourse/components/d-modal";
 import { emojiUnescape } from "discourse/lib/text";
 import { i18n } from "discourse-i18n";
 import { randomizeEmojiDiversity } from "../../lib/emoji-diversity";
+import UcdWarning from "../ucd-warning";
 
 export default class ModalUcdWarning extends Component {
   @service ucdState;
@@ -27,4 +29,15 @@ export default class ModalUcdWarning extends Component {
 
     this.args.closeModal();
   }
+
+  <template>
+    <DModal
+      @closeModal={{this.closeModal}}
+      class="modal-ucd-warning"
+      @title={{this.title}}
+      @inline={{@inline}}
+    >
+      <UcdWarning @onClose={{this.closeModal}} />
+    </DModal>
+  </template>
 }

javascripts/discourse/components/modal/ucd-warning.hbs

@@ -0,0 +1,63 @@
+import Component from "@glimmer/component";
+import { Input } from "@ember/component";
+import { inject as controller } from "@ember/controller";
+import { on } from "@ember/modifier";
+import { action } from "@ember/object";
+import { service } from "@ember/service";
+import CookText from "discourse/components/cook-text";
+import DButton from "discourse/components/d-button";
+import { i18n } from "discourse-i18n";
+
+export default class UcdWarning extends Component {
+  @service modal;
+  @service ucdState;
+
+  @controller composer;
+
+  get shouldPermanentlyDismiss() {
+    return this.ucdState.permanentlyDismissed ?? false;
+  }
+
+  @action
+  toggleShouldPermanentlyDismiss() {
+    this.ucdState.toggle();
+  }
+
+  @action
+  goBackAndFix() {
+    this.modal.close();
+  }
+
+  @action
+  ignoreAndProceed() {
+    this.modal.close();
+    this.composer.model.ucd_previousWarningIgnored = true;
+    this.composer.save();
+  }
+
+  <template>
+    <CookText @rawText={{i18n (themePrefix "warning_modal.content")}} />
+    <label for="ucd_do-not-show-again" class="checkbox-label">
+      <Input
+        @type="checkbox"
+        id="ucd_do-not-show-again"
+        name="ucd_do-not-show-again"
+        @checked={{readonly this.shouldPermanentlyDismiss}}
+        {{on "change" this.toggleShouldPermanentlyDismiss}}
+      />
+      {{i18n (themePrefix "warning_modal.do_not_show_again")}}
+    </label>
+    <div class="action-buttons">
+      <DButton
+        @action={{this.goBackAndFix}}
+        @icon="pencil"
+        class="btn-primary"
+        @label={{themePrefix "warning_modal.fix_post"}}
+      />
+      <DButton
+        @action={{this.ignoreAndProceed}}
+        @label={{themePrefix "warning_modal.ignore_and_post_anyway"}}
+      />
+    </div>
+  </template>
+}

javascripts/discourse/components/ucd-warning.gjs

@@ -1,11 +1,11 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.11.1",
-    "ember-template-lint": "7.0.1",
-    "eslint": "9.22.0",
+    "@discourse/lint-configs": "2.25.0",
+    "ember-template-lint": "7.8.1",
+    "eslint": "9.28.0",
     "prettier": "3.5.3",
-    "stylelint": "16.16.0"
+    "stylelint": "16.20.0"
   },
   "engines": {
     "node": ">= 22",