Skip to content

Commit cb4aa03

Browse files
authored
Merge pull request #2 from distinction-dev/feat/custom-configuration
feat: ✨ Added custom configuration part to be used in plugin
2 parents 14e4248 + e08794e commit cb4aa03

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

index.js

+12-6
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = class CfParametersPlugin {
1414
options: {
1515
[OPTION_PARAMETER_FILE]: {
1616
usage: 'Provide a JSON file to define secrets and parameters',
17-
required: true,
17+
required: false,
1818
type: 'string'
1919
},
2020
[OPTION_PARAMETER_OVERRIDES]: {
@@ -43,9 +43,14 @@ module.exports = class CfParametersPlugin {
4343
}
4444

4545
addSecretsAndParameters() {
46-
const parameterFile = this.options[OPTION_PARAMETER_FILE];
46+
let parameterFile = this.options[OPTION_PARAMETER_FILE];
47+
48+
if (!parameterFile) {
49+
parameterFile = this.serverless.service.custom?.dynamicSecretsConfig?.parameterFile;
50+
}
51+
4752
if (!parameterFile) {
48-
throw new Error("The --parameter-file option is required to define secrets and parameters.");
53+
throw new Error("❌ Parameter file is missing! Please provide it via CLI (--parameter-file <file>) or define it in serverless.yml under 'custom.dynamicSecretsConfig.parameterFile'.");
4954
}
5055

5156
const secretsData = JSON.parse(fs.readFileSync(parameterFile, 'utf-8'));
@@ -172,9 +177,10 @@ module.exports = class CfParametersPlugin {
172177
);
173178
// console.log("Parameter Overrides from CLI:", JSON.stringify(cliOverrides));
174179

175-
const fileOverrides = this.options[OPTION_PARAMETER_FILE]
176-
? JSON.parse(fs.readFileSync(this.options[OPTION_PARAMETER_FILE], 'utf-8'))
177-
: {};
180+
let parameterFile = this.options[OPTION_PARAMETER_FILE] || this.serverless.service.custom?.dynamicSecretsConfig?.parameterFile;
181+
const fileOverrides = parameterFile
182+
? JSON.parse(fs.readFileSync(parameterFile, 'utf-8'))
183+
: {};
178184

179185
// console.log("Parameter Overrides from File:", JSON.stringify(fileOverrides));
180186

0 commit comments

Comments
 (0)