Skip to content

Commit 1430568

Browse files
Smolevichjenssegers
authored andcommitted
use env values from phpunit.xml, update database.php and queue.php (mongodb#1738)
* use env values from phpunit.xml, update database.php and queue.php * Add .editorconfig * Update QueueTest.php * Update phpunit.xml.dist * Use in casting instead intval
1 parent e2a8fae commit 1430568

File tree

4 files changed

+41
-20
lines changed

4 files changed

+41
-20
lines changed

.editorconfig

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
root = true
2+
3+
[*]
4+
charset = utf-8
5+
end_of_line = lf
6+
insert_final_newline = true
7+
indent_style = space
8+
indent_size = 4
9+
trim_trailing_whitespace = true

phpunit.xml.dist

+20-11
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,40 @@
1515
<directory>tests/</directory>
1616
</testsuite>
1717
<testsuite name="schema">
18-
<directory>tests/SchemaTest.php</directory>
18+
<file>tests/SchemaTest.php</file>
1919
</testsuite>
2020
<testsuite name="seeder">
21-
<directory>tests/SeederTest.php</directory>
21+
<file>tests/SeederTest.php</file>
2222
</testsuite>
2323
<testsuite name="cache">
24-
<directory>tests/CacheTest.php</directory>
24+
<file>tests/CacheTest.php</file>
2525
</testsuite>
2626
<testsuite name="builder">
27-
<directory>tests/QueryBuilderTest.php</directory>
28-
<directory>tests/QueryTest.php</directory>
27+
<file>tests/QueryBuilderTest.php</file>
28+
<file>tests/QueryTest.php</file>
2929
</testsuite>
3030
<testsuite name="model">
31-
<directory>tests/ModelTest.php</directory>
32-
<directory>tests/RelationsTest.php</directory>
31+
<file>tests/ModelTest.php</file>
32+
<file>tests/RelationsTest.php</file>
3333
</testsuite>
3434
<testsuite name="relations">
35-
<directory>tests/RelationsTest.php</directory>
36-
<directory>tests/EmbeddedRelationsTest.php</directory>
35+
<file>tests/RelationsTest.php</file>
36+
<file>tests/EmbeddedRelationsTest.php</file>
3737
</testsuite>
3838
<testsuite name="mysqlrelations">
39-
<directory>tests/RelationsTest.php</directory>
39+
<file>tests/RelationsTest.php</file>
4040
</testsuite>
4141
<testsuite name="validation">
42-
<directory>tests/ValidationTest.php</directory>
42+
<file>tests/ValidationTest.php</file>
4343
</testsuite>
4444
</testsuites>
45+
<php>
46+
<env name="MONGO_HOST" value="mongodb"/>
47+
<env name="MONGO_DATABASE" value="unittest"/>
48+
<env name="MONGO_PORT" value="27017"/>
49+
<env name="MYSQL_HOST" value="mysql"/>
50+
<env name="MYSQL_DATABASE" value="unittest"/>
51+
<env name="MYSQL_USERNAME" value="root"/>
52+
<env name="QUEUE_CONNECTION" value="database"/>
53+
</php>
4554
</phpunit>

tests/config/database.php

+10-7
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,30 @@
11
<?php
22

3+
$mongoHost = env('MONGO_HOST', 'mongodb');
4+
$mongoPort = env('MONGO_PORT') ? (int) env('MONGO_PORT') : 27017;
5+
36
return [
47

58
'connections' => [
69

710
'mongodb' => [
811
'name' => 'mongodb',
912
'driver' => 'mongodb',
10-
'host' => 'mongodb',
11-
'database' => 'unittest',
13+
'host' => $mongoHost,
14+
'database' => env('MONGO_DATABASE', 'unittest'),
1215
],
1316

1417
'dsn_mongodb' => [
1518
'driver' => 'mongodb',
16-
'dsn' => 'mongodb://mongodb:27017',
17-
'database' => 'unittest',
19+
'dsn' => "mongodb://$mongoHost:$mongoPort",
20+
'database' => env('MONGO_DATABASE', 'unittest'),
1821
],
1922

2023
'mysql' => [
2124
'driver' => 'mysql',
22-
'host' => 'mysql',
23-
'database' => 'unittest',
24-
'username' => 'root',
25+
'host' => env('MYSQL_HOST', 'mysql'),
26+
'database' => env('MYSQL_DATABASE', 'unittest'),
27+
'username' => env('MYSQL_USERNAME', 'root'),
2528
'password' => '',
2629
'charset' => 'utf8',
2730
'collation' => 'utf8_unicode_ci',

tests/config/queue.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
return [
44

5-
'default' => 'database',
5+
'default' => env('QUEUE_CONNECTION'),
66

77
'connections' => [
88

@@ -16,7 +16,7 @@
1616
],
1717

1818
'failed' => [
19-
'database' => 'mongodb',
19+
'database' => env('MONGO_DATABASE'),
2020
'table' => 'failed_jobs',
2121
],
2222

0 commit comments

Comments
 (0)