-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace internal object description string with a configuration #35
Comments
We use a string as it is a flexible data type with simplest handling. And of course it is a good idea to replace a struct with a proper object, which is extendable at wish. But think about a good object structure first! |
example: class ObjectConfiguration
{
string name;
enum type;
io::path meshFileName;
core::vector3df position;
;
;
;
} |
We should think about replacing even the scriptual string creation, as well as the stack handling. |
Or we just use a class holding a JSON or YAML object instead, with defaults and accessors. |
This is related to the 3D object creation #22.
Most of the time, a C++ configuration object is way faster and a bit smaller than a string.
Check why we use the string in the first case, and check if it would be a good idea to replace it with a proper configuration object.
The text was updated successfully, but these errors were encountered: