Skip to content

Commit 589863c

Browse files
committed
Merge branch 'refs/heads/v3'
# Conflicts: # docs/changelog.md # pyproject.toml # scheduler/tests/test_internals.py
2 parents b58dafc + 4bb0852 commit 589863c

File tree

4 files changed

+17
-7
lines changed

4 files changed

+17
-7
lines changed

docs/changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ Settings:
3636
```
3737
- For how to configure in `settings.py`, please see the [settings documentation](./configuration.md).
3838

39+
## v3.0.2 🌈
40+
41+
### 🐛 Bug Fixes
42+
43+
- Fix issue updating wrong field #233
44+
3945
## v3.0.1 🌈
4046

4147
### 🐛 Bug Fixes

poetry.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scheduler/models/task.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ def save(self, **kwargs):
369369
schedule_job = kwargs.pop("schedule_job", True)
370370
update_fields = kwargs.get("update_fields", None)
371371
if update_fields is not None:
372-
kwargs["update_fields"] = set(update_fields).union({"modified"})
372+
kwargs["update_fields"] = set(update_fields).union({"updated_at"})
373373
super(Task, self).save(**kwargs)
374374
if schedule_job:
375375
self._schedule()

scheduler/tests/test_internals.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ def test_get_scheduled_job(self):
1717
with self.assertRaises(ValueError):
1818
get_scheduled_task("UNKNOWN_JOBTYPE", task.id)
1919

20+
def test_task_update(self):
21+
task = task_factory(TaskType.ONCE)
22+
task.name = "new_name"
23+
task.save(update_fields=["name"])
2024
def test_callback_bad_arguments(self):
2125
with self.assertRaises(CallbackSetupError) as cm:
2226
Callback("scheduler.tests.jobs.test_job", "1m")

0 commit comments

Comments
 (0)