Skip to content

Commit 83e5100

Browse files
authored
Merge pull request #74 from rdmolony/replace-namedtemporaryfile-with-temporaryfile
fix(windows): replace NamedTemporaryFile with TemporaryFile
2 parents 5352919 + 9e180a8 commit 83e5100

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

drf_excel/renderers.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import json
22
from collections.abc import Iterable, MutableMapping
3-
from tempfile import NamedTemporaryFile
3+
from tempfile import TemporaryFile
44
from typing import Dict
55

66
from openpyxl import Workbook
@@ -215,12 +215,11 @@ def render(self, data, accepted_media_type=None, renderer_context=None):
215215
return self._save_virtual_workbook(wb)
216216

217217
def _save_virtual_workbook(self, wb):
218-
tmp = NamedTemporaryFile()
219-
save_workbook(wb, tmp.name)
220-
221-
tmp.seek(0)
222-
virtual_workbook = tmp.read()
223-
tmp.close()
218+
with TemporaryFile() as tmp:
219+
save_workbook(wb, tmp)
220+
tmp.seek(0)
221+
virtual_workbook = tmp.read()
222+
224223

225224
return virtual_workbook
226225

0 commit comments

Comments
 (0)