Skip to content

Shadow-looking background on comments #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmispelon opened this issue Jan 25, 2024 · 1 comment
Closed

Shadow-looking background on comments #163

bmispelon opened this issue Jan 25, 2024 · 1 comment
Assignees
@bmispelon
Labels
styling Issues that deal with styling

Comments

@bmispelon
Copy link
Member

There's a weird shadow-looking horizontal bar under comment titles on the ticket page:

Screenshot 2024-01-25 at 22-09-49 #35141 (CACHE_MIDDLEWARE_SECONDS can be set to a float but has to be an int) – Django

It's not a box-shadow (that would have been caught by the noshadows.py script), this time it seems to be a fancy CSS background. Disabling the background completely looks a bit too empty, so I'm not sure how to replace it (maybe a simpler line rather than a gradient?).
We should also try to figure out if other elements are affected.
@bmispelon bmispelon added the styling Issues that deal with styling label Jan 25, 2024
@bmispelon bmispelon mentioned this issue Jan 25, 2024
Closed
@bmispelon bmispelon self-assigned this Jan 26, 2024
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jan 26, 2024
@bmispelon
Improved styling of comment header on ticket page
90ef584 
Fixes django#164 django#163
@bmispelon bmispelon mentioned this issue Jan 26, 2024
Merged
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jan 26, 2024
@bmispelon
Improved styling of comment header on ticket page
0b7d045 
Fixes django#164 django#163
felixxm pushed a commit that referenced this issue Jan 26, 2024
@bmispelon @felixxm
Improved styling of comment header on ticket page
ff647b6 
Fixes #164 #163
@felixxm
Copy link
Member

felixxm commented Jan 26, 2024

Fixed.

@felixxm felixxm closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmispelon bmispelon

Labels
styling Issues that deal with styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmispelon @felixxm