-
-
Notifications
You must be signed in to change notification settings - Fork 993
Simplify header text in community pages #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like to do this please assign this issue to me |
Done ✅ For future reference, you don't need to be assigned to an issue to work on it. You can simply leave a comment on the ticket, that's enough to inform people that you're working on it, and to avoid two people working on the same ticket at the same time. |
Added the 'depth' keyword and set it to 1 to simplify header text in community pages Issue resolved: Simplify header text in community pages django#1563
from datetime import date DJANGO_DOB = date(2005, 7, 14) def community_stats(request): |
@bmispelon I've submitted a PR to address the issue with simplifying the header text on the community pages. Please check out PR #1614 and let me know if any further adjustments are needed. Thanks! |
|
Is this issue still open ?... if yes then please assign it to me. |
Hi @rahulgrover-rg ,I am mamatha, i made a pull request of this issue, The PR is ready for review, will you please let me know if there are any other changes required. |
Sure why not! Let me review it. |
Hi, I’m Saparya, and I’d like to work on this issue. I’ve reviewed the description and understand that the goal is to simplify the header text on community pages. I plan to:
Let me know if there are any specific requirements or additional details I should consider before starting. Thanks! |
Thank you for your interest @saparya05! There are already two PRs open for this: #1614, #1851. Are you ok to review them and provide feedback on them? |
Currently the header in the community pages looks like this:
The text "Building the Django Community for 18 years, 11 months. Come join us!" is a bit too detailed, and based on a comment in the code, it seems like it was intended to be shorter:
djangoproject.com/aggregator/context_processors.py
Line 14 in f03f53f
Ideally, the text should read "for 18 years", which would be done by using
timesince(..., depth=1)
as the comment linked above mentions. A test would also be needed (in theaggregator/tests.py
file).This could be a good first-time contribution, anyone should feel free to try and send a PR.
The text was updated successfully, but these errors were encountered: