Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from key files not properly respected - breaks based on file name #426

Open
numericOverflow opened this issue Jan 11, 2025 · 0 comments

Comments

@numericOverflow
Copy link

numericOverflow commented Jan 11, 2025

I have a new edge case for #369. That commit mostly solved the comment workaround but...

If you attach public & private key but don't follow the "standard" naming convention, the public key isn't matched and therefore won't lookup the comment.

Works:

  • id_repro1 & id_repro1.pub

Doesn't work:

  • id_repro1.key & id_repro1.pub

  • filename.xxx & filename.pub

  • filename.anything & filename.pub

Steps to reproduce:

Use the keypairs same files from the zip file attached to that issue

  • Rename id_repro1 to id_repro1.key (or anything other than the bare, extension-less, typical name for a private key file)

    • image
  • attach the id_repro1.key

  • attach the id_repro1.pub

    • image
  • allow keyagent to use the entry

  • Manage keyfiles, pick the id_repro1.key

    • image
  • Comment does not appear.

    • image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant