Fix pylint errors. (#11748)

trivialfis · web-flow · commit b3124484fcbf · 2025-10-14T04:55:12.000+08:00
diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml
@@ -62,6 +62,7 @@ ignore = ["tests"]
 extension-pkg-whitelist = ["numpy", "cuda"]
 disable = [
     "import-error",
+    "invalid-name",
     "attribute-defined-outside-init",
     "import-outside-toplevel",
     "too-few-public-methods",
diff --git a/python-package/pyproject.toml.in b/python-package/pyproject.toml.in
@@ -61,6 +61,7 @@ ignore = ["tests"]
 extension-pkg-whitelist = ["numpy", "cuda"]
 disable = [
     "import-error",
+    "invalid-name",
     "attribute-defined-outside-init",
     "import-outside-toplevel",
     "too-few-public-methods",
diff --git a/python-package/xgboost/_typing.py b/python-package/xgboost/_typing.py
@@ -40,7 +40,7 @@
 
 CupyT = ArrayLike  # maybe need a stub for cupy arrays
 NumpyOrCupy = Any
-NumpyDType = Union[str, Type[np.number]]  # pylint: disable=invalid-name
+NumpyDType = Union[str, Type[np.number]]
 PandasDType = Any  # real type is pandas.core.dtypes.base.ExtensionDtype
 
 FloatCompatible = Union[float, np.float32, np.float64]
diff --git a/python-package/xgboost/callback.py b/python-package/xgboost/callback.py
@@ -55,7 +55,6 @@ class TrainingCallback(ABC):
 
     """
 
-    # pylint: disable=invalid-name
     EvalsLog: TypeAlias = EvalsLog
 
     def __init__(self) -> None:
diff --git a/python-package/xgboost/collective.py b/python-package/xgboost/collective.py
@@ -256,7 +256,7 @@ class Op(IntEnum):
     BITWISE_XOR = 5
 
 
-def allreduce(data: np.ndarray, op: Op) -> np.ndarray:  # pylint:disable=invalid-name
+def allreduce(data: np.ndarray, op: Op) -> np.ndarray:
     """Perform allreduce, return the result.
 
     Parameters
diff --git a/python-package/xgboost/compat.py b/python-package/xgboost/compat.py
@@ -1,4 +1,4 @@
-# pylint: disable=invalid-name,unused-import
+# pylint: disable=unused-import
 """For compatibility and optional dependencies."""
 import functools
 import importlib.util
diff --git a/python-package/xgboost/core.py b/python-package/xgboost/core.py
@@ -1,4 +1,4 @@
-# pylint: disable=too-many-arguments, too-many-branches, invalid-name
+# pylint: disable=too-many-arguments, too-many-branches
 # pylint: disable=too-many-lines, too-many-locals
 """Core XGBoost Library."""
 
@@ -1977,7 +1977,6 @@ def __init__(
         cache: Optional[Sequence[DMatrix]] = None,
         model_file: Optional[Union["Booster", bytearray, os.PathLike, str]] = None,
     ) -> None:
-        # pylint: disable=invalid-name
         """
         Parameters
         ----------
@@ -2509,7 +2508,6 @@ def eval_set(
         feval: Optional[Metric] = None,
         output_margin: bool = True,
     ) -> str:
-        # pylint: disable=invalid-name
         """Evaluate a set of data.
 
         Parameters
diff --git a/python-package/xgboost/dask/__init__.py b/python-package/xgboost/dask/__init__.py
@@ -1,5 +1,5 @@
 # pylint: disable=too-many-arguments, too-many-locals
-# pylint: disable=missing-class-docstring, invalid-name
+# pylint: disable=missing-class-docstring
 # pylint: disable=too-many-lines
 """
 Dask extensions for distributed training
diff --git a/python-package/xgboost/dask/utils.py b/python-package/xgboost/dask/utils.py
@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name
 """Utilities for the XGBoost Dask interface."""
 
 import logging
diff --git a/python-package/xgboost/data.py b/python-package/xgboost/data.py
@@ -1619,7 +1619,7 @@ class SingleBatchInternalIter(DataIter):  # pylint: disable=R0902
 
     def __init__(self, **kwargs: Any) -> None:
         self.kwargs = kwargs
-        self.it = 0  # pylint: disable=invalid-name
+        self.it = 0
 
         # This does not necessarily increase memory usage as the data transformation
         # might use memory.
diff --git a/python-package/xgboost/plotting.py b/python-package/xgboost/plotting.py
@@ -1,4 +1,4 @@
-# pylint: disable=too-many-locals, too-many-arguments, invalid-name,
+# pylint: disable=too-many-locals, too-many-arguments
 # pylint: disable=too-many-branches
 """Plotting Library."""
 import json
diff --git a/python-package/xgboost/sklearn.py b/python-package/xgboost/sklearn.py
@@ -1,4 +1,4 @@
-# pylint: disable=too-many-arguments, too-many-locals, invalid-name, fixme, too-many-lines
+# pylint: disable=too-many-arguments, too-many-locals, fixme, too-many-lines
 """Scikit-Learn Wrapper interface for XGBoost."""
 
 import collections
@@ -1057,7 +1057,7 @@ def get_params(self, deep: bool = True) -> Dict[str, Any]:
         #                     XGBRegressor -> XGBModel -> BaseEstimator
         #                                     XGBModel -> BaseEstimator
         #
-        params = super().get_params(deep)
+        params = super().get_params(deep)  # pylint: disable=no-member
         cp = copy.copy(self)
         # If the immediate parent defines get_params(), use that.
         if callable(getattr(cp.__class__.__bases__[0], "get_params", None)):
@@ -1277,7 +1277,7 @@ def fit(
         base_margin_eval_set: Optional[Sequence[ArrayLike]] = None,
         feature_weights: Optional[ArrayLike] = None,
     ) -> "XGBModel":
-        # pylint: disable=invalid-name,attribute-defined-outside-init
+        # pylint: disable=attribute-defined-outside-init
         """Fit gradient boosting model.
 
         Note that calling ``fit()`` multiple times will cause the model object to be
@@ -1692,7 +1692,7 @@ def _cls_predict_proba(n_classes: int, prediction: PredtT, vstack: Callable) ->
 """,
 )
 class XGBClassifier(XGBClassifierBase, XGBModel):
-    # pylint: disable=missing-docstring,invalid-name,too-many-instance-attributes
+    # pylint: disable=missing-docstring,too-many-instance-attributes
     @_deprecate_positional_args
     def __init__(
         self,
@@ -2140,7 +2140,7 @@ def _get_qid(
         :py:meth:`fit` for more info.""",
 )
 class XGBRanker(XGBRankerMixIn, XGBModel):
-    # pylint: disable=missing-docstring,too-many-arguments,invalid-name
+    # pylint: disable=missing-docstring,too-many-arguments
     @_deprecate_positional_args
     def __init__(self, *, objective: str = "rank:ndcg", **kwargs: Any):
         super().__init__(objective=objective, **kwargs)
diff --git a/python-package/xgboost/spark/core.py b/python-package/xgboost/spark/core.py
@@ -2,7 +2,7 @@
 
 import base64
 
-# pylint: disable=fixme, protected-access, no-member, invalid-name
+# pylint: disable=fixme, protected-access, no-member
 # pylint: disable=too-many-lines, too-many-branches
 import json
 import logging
@@ -626,7 +626,7 @@ def __init__(self) -> None:
 
         self.logger = get_logger(self.__class__.__name__)
 
-    def setParams(self, **kwargs: Any) -> None:  # pylint: disable=invalid-name
+    def setParams(self, **kwargs: Any) -> None:
         """
         Set params for the estimator.
         """
diff --git a/python-package/xgboost/spark/estimator.py b/python-package/xgboost/spark/estimator.py
@@ -1,6 +1,6 @@
 """Xgboost pyspark integration submodule for estimator API."""
 
-# pylint: disable=protected-access, no-member, invalid-name
+# pylint: disable=protected-access, no-member
 # pylint: disable=unused-argument, too-many-locals
 
 from typing import Any, List, Optional, Type, Union
diff --git a/python-package/xgboost/testing/__init__.py b/python-package/xgboost/testing/__init__.py
@@ -3,7 +3,7 @@
 
 """
 
-# pylint: disable=invalid-name,missing-function-docstring
+# pylint: disable=missing-function-docstring
 import importlib.util
 import os
 import platform
diff --git a/python-package/xgboost/testing/dask.py b/python-package/xgboost/testing/dask.py
@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name
 """Tests for dask shared by different test modules."""
 
 from typing import Any, List, Literal, Tuple, Type, cast
diff --git a/python-package/xgboost/testing/data.py b/python-package/xgboost/testing/data.py
@@ -1,4 +1,4 @@
-# pylint: disable=invalid-name, too-many-lines
+# pylint: disable=too-many-lines
 """Utilities for data generation."""
 import gc
 import multiprocessing
diff --git a/python-package/xgboost/testing/ordinal.py b/python-package/xgboost/testing/ordinal.py
@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name
 """Tests for the ordinal re-coder."""
 
 import itertools
diff --git a/python-package/xgboost/testing/predict.py b/python-package/xgboost/testing/predict.py
@@ -12,7 +12,7 @@
 from .utils import Device
 
 
-# pylint: disable=invalid-name,too-many-locals
+# pylint: disable=too-many-locals
 def run_predict_leaf(device: Device, DMatrixT: Type[DMatrix]) -> np.ndarray:
     """Run tests for leaf index prediction."""
     rows = 100
diff --git a/python-package/xgboost/testing/shared.py b/python-package/xgboost/testing/shared.py
@@ -1,6 +1,5 @@
 """Testing code shared by other tests."""
 
-# pylint: disable=invalid-name
 import collections
 import importlib.util
 import json
diff --git a/python-package/xgboost/testing/with_skl.py b/python-package/xgboost/testing/with_skl.py
@@ -1,4 +1,4 @@
-# pylint: disable=invalid-name, too-many-arguments, too-many-positional-arguments
+# pylint: disable=too-many-arguments, too-many-positional-arguments
 """Tests for compatiblity with sklearn."""
 
 from typing import Callable, Optional, Type
diff --git a/python-package/xgboost/training.py b/python-package/xgboost/training.py
@@ -1,4 +1,4 @@
-# pylint: disable=too-many-locals, too-many-arguments, invalid-name
+# pylint: disable=too-many-locals, too-many-arguments
 # pylint: disable=too-many-branches, too-many-statements
 """Training Library containing training routines."""
 import copy
@@ -452,7 +452,6 @@ def cv(
     shuffle: bool = True,
     custom_metric: Optional[Metric] = None,
 ) -> Union[Dict[str, float], "PdDataFrame"]:
-    # pylint: disable = invalid-name
     """Cross-validation with given parameters.
 
     Parameters

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# pylint: disable=invalid-name,unused-import`
	`1`	`+# pylint: disable=unused-import`
`2`	`2`	`"""For compatibility and optional dependencies."""`
`3`	`3`	`import functools`
`4`	`4`	`import importlib.util`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# pylint: disable=invalid-name`
`2`	`1`	`"""Utilities for the XGBoost Dask interface."""`
`3`	`2`
`4`	`3`	`import logging`