[jvm-packages] Supports external memory #11186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @trivialfis, please help review |
Member
|
Note:
|
Member
|
We need to let XGBoost access as many CPU threads as available. |
Member
|
Member
|
For reference, the |
Member
|
The two remaining items:
|
9 tasks
trivialfis
reviewed
Feb 14, 2025
...ckages/xgboost4j-spark-gpu/src/main/scala/ml/dmlc/xgboost4j/scala/spark/ExternalMemory.scala
Outdated
Show resolved
Hide resolved
…t4j/scala/spark/ExternalMemory.scala Co-authored-by: Jiaming Yuan <[email protected]>
Contributor
Author
|
Hi @trivialfis, please help review it. |
Member
|
Will review. I have tested the PR on my local machine with 2 GPUs.
|
trivialfis
reviewed
Feb 22, 2025
| inputNextIsCalled = true | ||
| withResource(new GpuColumnBatch(iter.next())) { batch => | ||
| if (iter.eq(input)) { | ||
| externalMemory.cacheTable(batch.table) |
Member
There was a problem hiding this comment.
It would be great if we could write data asynchronously in the future (after this PR). This way, we can let XGBoost handle the batch while it's being written simultaneously.
...ages/xgboost4j-spark-gpu/src/main/scala/ml/dmlc/xgboost4j/scala/spark/GpuXGBoostPlugin.scala
Show resolved
Hide resolved
...xgboost4j-spark-gpu/src/test/scala/ml/dmlc/xgboost4j/scala/spark/GpuXGBoostPluginSuite.scala
Show resolved
Hide resolved
trivialfis
reviewed
Feb 24, 2025
...s/xgboost4j-spark-gpu/src/test/scala/ml/dmlc/xgboost4j/scala/spark/ExternalMemorySuite.scala
Show resolved
Hide resolved
trivialfis
reviewed
Feb 25, 2025
| val path = Paths.get(dirPath) | ||
| if (!Files.exists(path)) { | ||
| Files.createDirectories(path) | ||
| } else { |
Member
There was a problem hiding this comment.
Empty else clause, is this intended?
Contributor
Author
There was a problem hiding this comment.
good catch. removed the empty else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting ext memory which is based on #11181