Update release scripts #11289
Merged
Update release scripts #11289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@hcho3 Could you please help take a look when you are available? I'm not sure how to proceed with the win64 xgboost-cpu along with the changed macos wheel. |
trivialfis
force-pushed
the
xgboost-cpu-build
branch
from
3c45ba6 to
c18edf0
Compare
hcho3
changed the title
trivialfis
commented
Feb 26, 2025
| IN_PATH = os.path.join(PY_PACKAGE, "pyproject.toml.in") | ||
| OUT_PATH = os.path.join(PY_PACKAGE, "pyproject.toml") | ||
|
|
||
| WHL_CPU = """ |
Member
Author
There was a problem hiding this comment.
We can probably add this to the toml file unconditionally.
Collaborator
Yes, the new tag should be sufficient. I added a test to ensure that the wheel can be installed into latest MacOS. I also added a CI pipeline to build |
hcho3
approved these changes
Feb 27, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Feb 27, 2025
This reverts commit 8bd70dd.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Feb 28, 2025
- Generate the variants instead of using patches. - Update links to s3 buckets. - Build the glibc warning into XGBoost instead of using a patch - Build xgboost-cpu on Windows --------- Co-authored-by: Hyunsu Cho <[email protected]>
trivialfis
added a commit
that referenced
this pull request
Feb 28, 2025
- Generate the variants instead of using patches. - Update links to s3 buckets. - Build the glibc warning into XGBoost instead of using a patch - Build xgboost-cpu on Windows --------- Co-authored-by: Hyunsu Cho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using simple string match and replace to generate files from templates. But we can switch to jinja if necessary (when things are more complicated than we can handle, say, many cuda versions).
In the long term, I would like to gather these scripts into a manager project.
todo
twine check.xgboost-cpuis missing for win64.macosx_10_15_x86_64.macosx_11_0_x86_64.macosx_12_0_x86_64is now simplymacosx_10_15_x86_64?