Skip to content

Conversation

@trivialfis
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated use_gpu parameter in favor of the device parameter across the codebase and tests.

  • Consolidates GPU logic around the new device parameter in estimator and core modules
  • Updates tests to replace all use_gpu usage with device="cpu" or device="cuda"
  • Adjusts documentation and docstrings to drop deprecated use_gpu references

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_distributed/test_with_spark/test_spark_local.py Replaced use_gpu in tests with device parameter
tests/test_distributed/test_gpu_with_spark/test_gpu_spark.py Updated classifier instantiation to use device="cuda"
python-package/xgboost/spark/params.py Changed docstring to refer to "GPU" instead of use_gpu
python-package/xgboost/spark/estimator.py Removed deprecated use_gpu import, warning, and handling
python-package/xgboost/spark/core.py Removed use_gpu param and default; updated _run_on_gpu logic

@trivialfis trivialfis requested a review from hcho3 July 11, 2025 05:54
@trivialfis
Copy link
Member Author

@wbo4958

@wbo4958
Copy link
Contributor

wbo4958 commented Jul 14, 2025

LGTM. But better to involve @WeichenXu123 to be aware of this PR.

@trivialfis trivialfis merged commit 82c536e into dmlc:master Jul 15, 2025
97 of 100 checks passed
@trivialfis trivialfis deleted the remove-spark-use-gpu branch July 15, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants