Fixes for the latest mypy. #11797
Merged
Fixes for the latest mypy. #11797
+14
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves code quality in the distributed testing suite through better variable naming and import handling. The changes make the test code clearer and remove unnecessary exception handling for imports that are already protected by pytest marks.
- Renamed variable from
ftotfto better indicate thread futures from ThreadPoolExecutor - Replaced try-except import block with direct imports for GPU-related Dask dependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_distributed/test_with_dask/test_with_dask.py | Improved variable naming by renaming f to tf for thread futures |
| tests/test_distributed/test_gpu_with_dask/test_gpu_with_dask.py | Simplified import structure by removing try-except block that was redundant with pytest skip marks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.