Skip to content

Fixes for the latest mypy. #11797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
+14 −18
Merged

Fixes for the latest mypy. #11797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions tests/test_distributed/test_gpu_with_dask/test_gpu_with_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,16 @@
tm.timeout(180),
]

try:
import cudf
import dask
import dask.dataframe as dd
from dask import __version__ as dask_version
from dask import array as da
from dask.distributed import Client
from dask_cuda import LocalCUDACluster

from xgboost import dask as dxgb
from xgboost.testing.dask import check_init_estimation, check_uneven_nan
except ImportError:
dask_version = None

import cudf
import dask
import dask.dataframe as dd
from dask import __version__ as dask_version
from dask import array as da
from dask.distributed import Client
from dask_cuda import LocalCUDACluster

from xgboost import dask as dxgb
from xgboost.testing.dask import check_init_estimation, check_uneven_nan

dask_version_ge110 = dask_version and parse_version(dask_version) >= parse_version(
"2024.11.0"
Expand Down
8 changes: 4 additions & 4 deletions tests/test_distributed/test_with_dask/test_with_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2061,11 +2061,11 @@ def test_parallel_submit_multi_clients() -> None:
def _() -> dxgb.DaskXGBClassifier:
return futures[i][0].compute(futures[i][1]).result()

f = e.submit(_)
t_futures.append(f)
tf = e.submit(_)
t_futures.append(tf)

for i, f in enumerate(t_futures):
assert f.result().get_booster().num_boosted_rounds() == i + 1
for i, tf in enumerate(t_futures):
assert tf.result().get_booster().num_boosted_rounds() == i + 1


def test_init_estimation(client: Client) -> None:
Expand Down
Loading