Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove telerik removal extention and PB entry in fresh DNN 10 installs #6351

Closed
2 of 4 tasks
enfJoao opened this issue Feb 3, 2025 · 5 comments
Closed
2 of 4 tasks

Comments

@enfJoao
Copy link

enfJoao commented Feb 3, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

Image

Description of solution

No reason for this to exist on a fresh DNN 10 install.

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@enfJoao enfJoao changed the title [Enhancement]: Remove telerik removal extention and PB entry [Enhancement]: Remove telerik removal extention and PB entry in fresh DNN 10 installs Feb 3, 2025
@valadas valadas added this to the 10.0.0 milestone Feb 3, 2025
@valadas
Copy link
Contributor

valadas commented Feb 3, 2025

We'll have to discuss this one, I believe the Telerik removal code is in this extension. So we may want to remove this in v10.1.0 or such But we could potentially hide it from the menu until its removal potentially.

@bdukes
Copy link
Contributor

bdukes commented Feb 3, 2025

It would be nice if the module uninstalled itself after removing Telerik.

@enfJoao
Copy link
Author

enfJoao commented Feb 8, 2025

Uninstalling the module on the extension manager did not remove the PB entry for me.

@bdukes
Copy link
Contributor

bdukes commented Feb 10, 2025

I've attempted to adjust things in #6355 to remove that page and PB entry upon uninstall (though my last test attempt it still didn't work, so I need to dig deeper into it)

@valadas
Copy link
Contributor

valadas commented Feb 13, 2025

Done in #6355

@valadas valadas closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants