Skip to content

Commit 0cf934c

Browse files
authored
Fix NoneType has no len() in DDG tool (langchain-ai#3334)
Per https://github.com/deedy5/duckduckgo_search/blob/46ac914daa614843cfa2ee3dd4663a5862e775a2/duckduckgo_search/ddg.py#L109, ddg function actually returns None when there is no result.
1 parent 2c00233 commit 0cf934c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

langchain/utilities/duckduckgo_search.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def run(self, query: str) -> str:
4949
time=self.time,
5050
max_results=self.max_results,
5151
)
52-
if len(results) == 0:
52+
if results is None or len(results) == 0:
5353
return "No good DuckDuckGo Search Result was found"
5454
snippets = [result["body"] for result in results]
5555
return " ".join(snippets)
@@ -77,7 +77,7 @@ def results(self, query: str, num_results: int) -> List[Dict]:
7777
max_results=num_results,
7878
)
7979

80-
if len(results) == 0:
80+
if results is None or len(results) == 0:
8181
return [{"Result": "No good DuckDuckGo Search Result was found"}]
8282

8383
def to_metadata(result: Dict) -> Dict:

0 commit comments

Comments
 (0)