Skip to content

Commit a0d1097

Browse files
authored
Merge pull request #188 from skyred/patch-38
Use the correct default composer version for 9.1.x version or above
2 parents e1c00ac + 174a405 commit a0d1097

File tree

12 files changed

+22
-21
lines changed

12 files changed

+22
-21
lines changed

8.9/apache-buster/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
6059
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release

8.9/fpm-alpine3.12/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ RUN { \
4646
echo 'opcache.fast_shutdown=1'; \
4747
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
4848

49-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
5049
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
5150

5251
# https://www.drupal.org/node/3060/release

8.9/fpm-buster/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
6059
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release

9.0/apache-buster/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
6059
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release

9.0/fpm-alpine3.12/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ RUN { \
4646
echo 'opcache.fast_shutdown=1'; \
4747
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
4848

49-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
5049
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
5150

5251
# https://www.drupal.org/node/3060/release

9.0/fpm-buster/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
6059
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release

9.1/apache-buster/Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
60-
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
59+
COPY --from=composer:2.0 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release
6362
ENV DRUPAL_VERSION 9.1.2

9.1/fpm-alpine3.12/Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ RUN { \
4646
echo 'opcache.fast_shutdown=1'; \
4747
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
4848

49-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
50-
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
49+
COPY --from=composer:2.0 /usr/bin/composer /usr/local/bin/
5150

5251
# https://www.drupal.org/node/3060/release
5352
ENV DRUPAL_VERSION 9.1.2

9.1/fpm-buster/Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
60-
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
59+
COPY --from=composer:2.0 /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release
6362
ENV DRUPAL_VERSION 9.1.2

Dockerfile-alpine.template

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ RUN { \
4646
echo 'opcache.fast_shutdown=1'; \
4747
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
4848

49-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
50-
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
49+
COPY --from=composer:%%COMPOSER_VERSION%% /usr/bin/composer /usr/local/bin/
5150

5251
# https://www.drupal.org/node/3060/release
5352
ENV DRUPAL_VERSION %%VERSION%%

Dockerfile-debian.template

+1-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ RUN { \
5656
echo 'opcache.fast_shutdown=1'; \
5757
} > /usr/local/etc/php/conf.d/opcache-recommended.ini
5858

59-
# https://github.com/drupal/drupal/blob/9.0.1/composer.lock#L4052-L4053
60-
COPY --from=composer:1.10 /usr/bin/composer /usr/local/bin/
59+
COPY --from=composer:%%COMPOSER_VERSION%% /usr/bin/composer /usr/local/bin/
6160

6261
# https://www.drupal.org/node/3060/release
6362
ENV DRUPAL_VERSION %%VERSION%%

update.sh

+17-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ declare -A phpVersions=(
1818
[9.0]='7.4'
1919
)
2020

21+
declare -A composerVersions=(
22+
[8.9]='1.10' # https://github.com/drupal/drupal/blob/8.9.12/composer.lock#L4357-L4358
23+
[9.0]='1.10' # https://github.com/drupal/drupal/blob/9.0.10/composer.lock#L4448-L4449
24+
[9.1]='2.0' # https://github.com/drupal/drupal/blob/9.1.2/composer.lock#L4730-L4731
25+
)
26+
2127
for version in "${versions[@]}"; do
2228
rcGrepV='-v'
2329
rcVersion="${version%-rc}"
@@ -68,16 +74,22 @@ for version in "${versions[@]}"; do
6874
fi
6975

7076
phpImage="${phpVersions[$version]:-$defaultPhpVersion}-$variant"
77+
sedArgs=(
78+
-e 's/%%PHP_VERSION%%/'"${phpImage}"'/'
79+
-e 's/%%VERSION%%/'"$fullVersion"'/'
80+
-e 's/%%MD5%%/'"$md5"'/'
81+
)
82+
7183
template="Dockerfile-$dist.template"
7284
if [ "$version" = '7' ]; then
7385
# 7 has no release in drupal/recommended-project
7486
# so its Dockerfile is based on the old template
7587
template="Dockerfile-7-$dist.template"
88+
else
89+
composerVersion="${composerVersions[$version]}"
90+
sedArgs+=( -e 's/%%COMPOSER_VERSION%%/'"$composerVersion"'/' )
7691
fi
77-
sed -r \
78-
-e 's/%%PHP_VERSION%%/'"${phpImage}"'/' \
79-
-e 's/%%VERSION%%/'"$fullVersion"'/' \
80-
-e 's/%%MD5%%/'"$md5"'/' \
81-
"$template" > "$version/$variant/Dockerfile"
92+
93+
sed -r "${sedArgs[@]}" "$template" > "$version/$variant/Dockerfile"
8294
done
8395
done

0 commit comments

Comments
 (0)