Skip to content

Commit ce1ddb6

Browse files
committed
fix combination of --pull always --no-build
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent c582470 commit ce1ddb6

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

cmd/compose/create.go

-10
Original file line numberDiff line numberDiff line change
@@ -159,16 +159,6 @@ func (opts createOptions) Apply(project *types.Project) error {
159159
project.Services[i] = service
160160
}
161161
}
162-
// opts.noBuild, however, means do not perform ANY builds
163-
if opts.noBuild {
164-
for i, service := range project.Services {
165-
service.Build = nil
166-
if service.Image == "" {
167-
service.Image = api.GetImageNameOrDefault(service, project.Name)
168-
}
169-
project.Services[i] = service
170-
}
171-
}
172162

173163
if err := applyPlatforms(project, true); err != nil {
174164
return err

cmd/compose/up.go

-2
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,6 @@ func runUp(
177177
}
178178

179179
var build *api.BuildOptions
180-
// this check is technically redundant as createOptions::apply()
181-
// already removed all the build sections
182180
if !createOptions.noBuild {
183181
if createOptions.quietPull {
184182
buildOptions.Progress = string(xprogress.QuietMode)

0 commit comments

Comments
 (0)