Skip to content

Commit

Permalink
fix engine version require to use healthcheck.start_interval
Browse files Browse the repository at this point in the history 
Signed-off-by: Nicolas De Loof <[email protected]>
  • Loading branch information
@ndeloof
ndeloof committed Jan 17, 2024
1 parent 3c4593f commit f414bf7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/compose/convert.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (s *composeService) ToMobyHealthCheck(ctx context.Context, check *compose.H
return nil, err
}
if versions.LessThan(version, "1.44") {
return nil, errors.New("can't set healthcheck.start_interval as feature require Docker Engine 1.25 or later")
return nil, errors.New("can't set healthcheck.start_interval as feature require Docker Engine v25 or later")
} else {
startInterval = time.Duration(*check.StartInterval)
}
Expand Down

3 comments on commit f414bf7

@fti-akumari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description:

I am encountering an issue with the start_interval parameter inDocker Compose version 2.26.1.It seems that the start_interval functionality is not working as expected in this version, whereas it functions properly in version 2.24.5.

Docker Compose version v2.26.1

Screenshot from 2024-04-03 18-33-46

Problem:

When attempting to use the start_interval parameter in version 2.26.1, I consistently encounter errors. However, in version 2.24.5, the same configuration works without any issues.

Error Message:

Screenshot from 2024-04-03 18-09-50

Reference

Steps to Reproduce:

  • Use Docker Compose version 2.26.1.
  • Configure a service with the start_interval parameter set to a specific value.
  • Attempt to deploy the service using Docker Compose.
  • Observe the error or unexpected behavior related to the start_interval parameter.

Expected Behavior:

The start_interval parameter should work consistently across different versions of Docker Compose. When specifying a start interval for a service, Docker Compose should honor this configuration and start the service accordingly.

@glours
Copy link
Contributor

@glours glours commented on f414bf7 Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fti-akumari can you please open an issue and not commenting the source code to describe your problem? It's easier for us to follow and track potential bugs

@fti-akumari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Please sign in to comment.