Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important content and general tips have reversed classes #2527

Closed
1 task done
w3teal opened this issue Jan 19, 2025 · 2 comments
Closed
1 task done

Important content and general tips have reversed classes #2527

w3teal opened this issue Jan 19, 2025 · 2 comments
Assignees

Comments

@w3teal
Copy link

w3teal commented Jan 19, 2025

Bug Report

Steps to reproduce

Create !> **Time** is money, my friend! and ?> _TODO_ unit test

Current behaviour

The !> is produce an element with class tip, meanwhile the ?> is produce an element with class warn (Which stands warning). I think the class is mixed up because the style doesn't follow the meaning of the class.

Image Image
<p class="tip"> <p class="warn">

Expected behaviour

Use more appropriate and clear classes for each callout. Using the .tip and .warn classes might still make sense after being reversed.

Other relevant information

  • Docsify version: 4.13.1
  • Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): No

Please create a reproducible sandbox

Edit Sandbox

Mention the docsify version in which this bug was not present (if any)

?

@paulhibbitts
Copy link
Collaborator

paulhibbitts commented Jan 19, 2025

Thanks for reporting this issue @LIGMATV . Docsify v5 is under development and should address this issue, you can preview the improved support for GitHub style callouts in the PR #2487 and an example Preview build at https://docsify-preview-docsifyjs.vercel.app/preview/#/ (the UI Kit example page at https://docsify-preview-docsifyjs.vercel.app/preview/#/ui-kit might be of particular interest)

@paulhibbitts paulhibbitts self-assigned this Jan 19, 2025
@w3teal w3teal changed the title Important content (!>) and general tips (?>) have reversed classes Important content and general tips have reversed classes Jan 20, 2025
@paulhibbitts
Copy link
Collaborator

I am closing this assuming the issue is not present in Docsify v5, please re-open if not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants