Skip to content

Commit 922d934

Browse files
committed
Avoid use of empty, remove unreachable branch
1 parent b46085b commit 922d934

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/Revisionable/RevisionableListener.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ private function getObjectChangeSetData(RevisionableAdapter $ea, object $object,
286286
$newValues = [];
287287

288288
foreach ($ea->getObjectChangeSet($uow, $object) as $field => $changes) {
289-
if (empty($config['versioned']) || !in_array($field, $config['versioned'], true)) {
289+
if (!isset($config['versioned']) || !in_array($field, $config['versioned'], true)) {
290290
continue;
291291
}
292292

@@ -372,11 +372,6 @@ private function createRevision(string $action, object $object, RevisionableAdap
372372

373373
if (RevisionInterface::ACTION_CREATE !== $action) {
374374
$version = $ea->getNewVersion($revisionMeta, $object);
375-
376-
if (empty($version)) {
377-
// was versioned later
378-
$version = 1;
379-
}
380375
}
381376

382377
$revision->setVersion($version);

0 commit comments

Comments
 (0)