From 8fbde0b391c563a0a008a1f4cc8c07e73eaa7d7f Mon Sep 17 00:00:00 2001
From: Mponos George <gmponos@gmail.com>
Date: Sat, 20 Jun 2020 22:56:08 +0300
Subject: [PATCH] Ban env functions

---
 lib/Doctrine/ruleset.xml | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/lib/Doctrine/ruleset.xml b/lib/Doctrine/ruleset.xml
index c0bf70bd..dc4316d2 100644
--- a/lib/Doctrine/ruleset.xml
+++ b/lib/Doctrine/ruleset.xml
@@ -62,32 +62,38 @@
     <rule ref="Generic.PHP.CharacterBeforePHPOpeningTag"/>
     <!-- Forbid deprecated functions -->
     <rule ref="Generic.PHP.DeprecatedFunctions"/>
-    <!-- Forbid alias functions, i.e. `sizeof()`, `delete()` -->
     <rule ref="Generic.PHP.ForbiddenFunctions">
         <properties>
             <property name="forbiddenFunctions" type="array">
+                <!-- Forbid alias functions, i.e. `sizeof()`, `delete()` -->
                 <element key="chop" value="rtrim"/>
                 <element key="close" value="closedir"/>
-                <element key="compact" value="null"/>
                 <element key="delete" value="unset"/>
                 <element key="doubleval" value="floatval"/>
-                <element key="extract" value="null"/>
                 <element key="fputs" value="fwrite"/>
                 <element key="ini_alter" value="ini_set"/>
                 <element key="is_double" value="is_float"/>
                 <element key="is_integer" value="is_int"/>
                 <element key="is_long" value="is_int"/>
-                <element key="is_null" value="null"/>
                 <element key="is_real" value="is_float"/>
                 <element key="is_writeable" value="is_writable"/>
                 <element key="join" value="implode"/>
                 <element key="key_exists" value="array_key_exists"/>
                 <element key="pos" value="current"/>
-                <element key="settype" value="null"/>
                 <element key="show_source" value="highlight_file"/>
                 <element key="sizeof" value="count"/>
                 <element key="strchr" value="strstr"/>
                 <element key="user_error" value="trigger_error"/>
+
+                <!-- depending on the following functions is considered a bad practice -->
+                <element key="compact" value="null"/>
+                <element key="extract" value="null"/>
+                <element key="is_null" value="null"/>
+                <element key="settype" value="null"/>
+
+                <!-- // use $_SERVER or $_ENV variable directly // https://github.com/laravel/framework/issues/7354 -->
+                <element key="putenv" value="null"/> 
+                <element key="getenv" value="null"/> 
             </property>
         </properties>
     </rule>