From f0180864ed5a954c706dde4a6bf8e35dde754109 Mon Sep 17 00:00:00 2001 From: Fabien Salathe Date: Thu, 16 Sep 2021 18:17:50 +0200 Subject: [PATCH 1/2] Fix "transactional" configuration --- .../Migrations/Configuration/Migration/ConfigurationArray.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php b/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php index 4c48f6723..aa4508d79 100644 --- a/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php +++ b/lib/Doctrine/Migrations/Configuration/Migration/ConfigurationArray.php @@ -62,7 +62,7 @@ public function getConfiguration(): Configuration $configuration->setAllOrNothing(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, false)); }, 'transactional' => static function ($value, Configuration $configuration): void { - $configuration->setAllOrNothing(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, true)); + $configuration->setTransactional(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, true)); }, 'check_database_platform' => static function ($value, Configuration $configuration): void { $configuration->setCheckDatabasePlatform(is_bool($value) ? $value : BooleanStringFormatter::toBoolean($value, false)); From f916614147f38b401cdf66321b63d77a3321749c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 16 Sep 2021 21:49:44 +0200 Subject: [PATCH 2/2] Adapt error message to new PHPStan version --- phpstan.neon.dist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 0789eee4a..40aebd634 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -11,7 +11,7 @@ parameters: message: '~^Call to function in_array\(\) requires parameter #3 to be true\.$~' path: %currentWorkingDirectory%/lib/Doctrine/Migrations/Version/SortedMigrationPlanCalculator.php - - message: '~^Variable property access on mixed\.$~' + message: '~^Variable property access on SimpleXMLElement\.$~' path: %currentWorkingDirectory%/lib/Doctrine/Migrations/Configuration/Migration/XmlFile.php - message: '~^Call to function is_bool\(\) with bool will always evaluate to true\.$~'