`FrozenDependencies` thrown when trying to run twice migration commands in the same runtime

[nikophil]

BC Break Report

Q	A
BC Break	yes
Version	3.8.0

Summary

Hello,

in zenstruck/foundry, we reset the database by using migrations. We allow to configure multiple configuration files for the migrations, which will basically result in a loop where we call doctrine:migration:migrate through doctrine/doctrine-migration-bundle.

Since this PR, this behavior is impossible because the second call to doctrine:migration:migrate will say the dependencies are frozen. (see zenstruck/foundry#889)

Maybe we could "unfroze" the DependencyFactory as soon as the migrations are run?

(I know another issue exists regarding FrozenDependencies exception, but I think the problem is different here)

How to reproduce

just call twice the migration mechanism with different configurations in the same runtime

thank you for you help!

[nikophil]

hey @greg0ire @VincentLanglet

would you see any solution for this? 🙏

I think this issue is the same than @leefant's comment

[VincentLanglet]

Maybe we could "unfroze" the DependencyFactory as soon as the migrations are run?

Indeed, that seems ok to me.

Main issue was to freeze the migration to report any call of addSql in postMethod

$migration->{'post' . ucfirst($direction)}($toSchema);

So it would be ok to unfreeze the migration at the end.

Do you want to try a PR for this ?

[nikophil]

Thanks for your answer @VincentLanglet

Do you want to try a PR for this ?

yeah I'll do this soon(-ish).