Skip to content

Commit 9ad3489

Browse files
authored
Merge pull request #3014 from dolthub/fulghum/exprs
Simplify implementation of `hasSingleOutput`
2 parents 3e99e22 + e928632 commit 9ad3489

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

sql/analyzer/apply_hash_in.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,13 @@ func applyHashIn(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Scope, s
5656

5757
// hasSingleOutput checks if an expression evaluates to a single output
5858
func hasSingleOutput(e sql.Expression) bool {
59-
return !transform.InspectExpr(e, func(expr sql.Expression) bool {
59+
return transform.InspectExpr(e, func(expr sql.Expression) bool {
6060
switch expr.(type) {
61-
case expression.Tuple, *expression.Literal, *expression.GetField,
62-
expression.Comparer, *expression.Convert, sql.FunctionExpression,
63-
*expression.IsTrue, *expression.IsNull, expression.ArithmeticOp:
61+
case *plan.Subquery:
6462
return false
6563
default:
6664
return true
6765
}
68-
return false
6966
})
7067
}
7168

0 commit comments

Comments
 (0)