Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Support for ISM #38

Open
daheise opened this issue Jun 16, 2020 · 0 comments
Open

JSON Support for ISM #38

daheise opened this issue Jun 16, 2020 · 0 comments

Comments

@daheise
Copy link

daheise commented Jun 16, 2020

I have been working on an update to the mod.json to enable support for ISM, since the ISM file on Nexus seems to have gotten out of sync. I'm not confident enough in my work, or where/if it belongs in your repo to issue a PR. You can view it here.

Here are issues I am not sure how to clean up/validate.

  1. How do I know a faction is safe to leave out of the "FactionTags", e.g. can I leave out HostileMercenaries?
  2. Do need to add a tag for each faction to FactionShopItems and FactionShops like for FactionTags? Will it cause issues if they're in any of these places but those faction shops aren't implemented?
  3. Is FactionStrings dead code? I don't have it in this json but it's easy to add back.
@daheise daheise changed the title Update Support for ISM JSON Support for ISM Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant