Skip to content

Commit e444d65

Browse files
authored
Merge pull request dotnet#6586 from kyulee1/fixbuildtest
ARM64: Fix Build Test Break
2 parents a8c8bea + dc2b355 commit e444d65

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

build-test.cmd

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ if [!processedArgs!]==[] (
5757

5858
:ArgsDone
5959

60+
echo %__MsgPrefix%Using environment: "%__VSToolsRoot%\VsDevCmd.bat"
61+
call "%__VSToolsRoot%\VsDevCmd.bat"
62+
6063
set __RunArgs=-BuildOS=%__BuildOS% -BuildType=%__BuildType% -BuildArch=%__BuildArch%
6164

6265
rem arm64 builds currently use private toolset which has not been released yet
@@ -155,7 +158,7 @@ if defined __ToolsetDir (
155158
)
156159

157160
set __BuildLogRootName=Tests_Native
158-
call %~dp0\run.cmd build -Project="%__NativeTestIntermediatesDir%\install.vcxproj" %__msbuildNativeArgs% %__RunArgs% %__unprocessedBuildArgs%
161+
call %__ProjectDir%\run.cmd build -Project="%__NativeTestIntermediatesDir%\install.vcxproj" %__msbuildNativeArgs% %__RunArgs% %__unprocessedBuildArgs%
159162
if errorlevel 1 exit /b 1
160163

161164
:skipnative
@@ -170,10 +173,6 @@ REM ============================================================================
170173

171174
echo %__MsgPrefix%Starting the Managed Tests Build
172175

173-
:: Set the environment for the managed build
174-
echo %__MsgPrefix%Using environment: "%__VSToolsRoot%\VsDevCmd.bat"
175-
call "%__VSToolsRoot%\VsDevCmd.bat"
176-
177176
if not defined VSINSTALLDIR (
178177
echo %__MsgPrefix%Error: buildtest.cmd should be run from a Visual Studio Command Prompt. Please see https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/developer-guide.md for build instructions.
179178
exit /b 1
@@ -191,7 +190,7 @@ if defined __UpdateInvalidPackagesArg (
191190
set __up=-updateinvalidpackageversions
192191
)
193192

194-
call %~dp0run.cmd build -buildManagedTests -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__up% %__RunArgs% %__unprocessedBuildArgs%
193+
call %__ProjectDir%\run.cmd build -Project=%__ProjectDir%\tests\build.proj -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__up% %__RunArgs% %__unprocessedBuildArgs%
195194
if errorlevel 1 (
196195
echo %__MsgPrefix%Error: build failed. Refer to the build log files for details:
197196
echo %__BuildLog%
@@ -212,7 +211,7 @@ set __msbuildLog=/flp:Verbosity=normal;LogFile="%__BuildLog%"
212211
set __msbuildWrn=/flp1:WarningsOnly;LogFile="%__BuildWrn%"
213212
set __msbuildErr=/flp2:ErrorsOnly;LogFile="%__BuildErr%"
214213

215-
call %~dp0run.cmd build -testOverlay -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__RunArgs% %__unprocessedBuildArgs%
214+
call %__ProjectDir%\run.cmd build -Project=%__ProjectDir%\tests\runtest.proj -testOverlay -MsBuildLog=!__msbuildLog! -MsBuildWrn=!__msbuildWrn! -MsBuildErr=!__msbuildErr! %__RunArgs% %__unprocessedBuildArgs%
216215
if errorlevel 1 (
217216
echo %__MsgPrefix%Error: build failed. Refer to the build log files for details:
218217
echo %__BuildLog%

config.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -333,16 +333,9 @@
333333
"testOverlay": {
334334
"description": "Runs test overlay target.",
335335
"settings": {
336-
"Project": "./tests/runtest.proj",
337336
"CreateTestOverlay": "default"
338337
}
339338
},
340-
"buildManagedTests": {
341-
"description": "Builds managed tests.",
342-
"settings": {
343-
"Project": "./tests/build.proj"
344-
}
345-
},
346339
"priority": {
347340
"description": "Sets CLRTestPriorityToBuild property.",
348341
"settings": {

0 commit comments

Comments
 (0)