From 44b1041e27ab31d81e00798ddb8c5271a66aee6a Mon Sep 17 00:00:00 2001 From: Shay Rojansky <roji@roji.org> Date: Fri, 25 Nov 2022 18:57:04 +0100 Subject: [PATCH 1/2] Add note on SqlClient async issues See https://github.com/dotnet/EntityFramework.Docs/issues/4109 --- aspnetcore/data/ef-rp/intro.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/aspnetcore/data/ef-rp/intro.md b/aspnetcore/data/ef-rp/intro.md index 98d6801ababe..61683759950a 100644 --- a/aspnetcore/data/ef-rp/intro.md +++ b/aspnetcore/data/ef-rp/intro.md @@ -518,6 +518,9 @@ Some things to be aware of when writing asynchronous code that uses EF Core: For more information about asynchronous programming in .NET, see [Async Overview](/dotnet/standard/async) and [Asynchronous programming with async and await](/dotnet/csharp/programming-guide/concepts/async/). +> [!WARNING] +> The async implementation of [Microsoft.Data.SqlClient](https://github.com/dotnet/SqlClient) unfortunately has some known issues (e.g. [#593](https://github.com/dotnet/SqlClient/issues/593), [#601](https://github.com/dotnet/SqlClient/issues/601), and others). If you're seeing unexpected performance problems, try using sync command execution instead, especially when dealing with large text or binary values. + <!-- Review: See https://github.com/dotnet/AspNetCore.Docs/issues/14528 --> ## Performance considerations From a305fcc4772ed16ead03fb41c25faff59a0fd6e1 Mon Sep 17 00:00:00 2001 From: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> Date: Sat, 26 Nov 2022 13:27:40 -1000 Subject: [PATCH 2/2] Update aspnetcore/data/ef-rp/intro.md --- aspnetcore/data/ef-rp/intro.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aspnetcore/data/ef-rp/intro.md b/aspnetcore/data/ef-rp/intro.md index 61683759950a..6af817fc24d2 100644 --- a/aspnetcore/data/ef-rp/intro.md +++ b/aspnetcore/data/ef-rp/intro.md @@ -519,7 +519,7 @@ Some things to be aware of when writing asynchronous code that uses EF Core: For more information about asynchronous programming in .NET, see [Async Overview](/dotnet/standard/async) and [Asynchronous programming with async and await](/dotnet/csharp/programming-guide/concepts/async/). > [!WARNING] -> The async implementation of [Microsoft.Data.SqlClient](https://github.com/dotnet/SqlClient) unfortunately has some known issues (e.g. [#593](https://github.com/dotnet/SqlClient/issues/593), [#601](https://github.com/dotnet/SqlClient/issues/601), and others). If you're seeing unexpected performance problems, try using sync command execution instead, especially when dealing with large text or binary values. +> The async implementation of [Microsoft.Data.SqlClient](https://github.com/dotnet/SqlClient) has some known issues ([#593](https://github.com/dotnet/SqlClient/issues/593), [#601](https://github.com/dotnet/SqlClient/issues/601), and others). If you're seeing unexpected performance problems, try using sync command execution instead, especially when dealing with large text or binary values. <!-- Review: See https://github.com/dotnet/AspNetCore.Docs/issues/14528 --> ## Performance considerations