rebased (#529)

Author: Emdot

src/Docker.DotNet/Endpoints/ContainerOperations.cs

@@ -20,6 +20,13 @@ internal class ContainerOperations : IContainerOperations
                 throw new DockerContainerNotFoundException(statusCode, responseBody);
             }
         };
+        internal static readonly ApiResponseErrorHandlingDelegate NoSuchImageHandler = (statusCode, responseBody) =>
+        {
+            if (statusCode == HttpStatusCode.NotFound)
+            {
+                throw new DockerImageNotFoundException(statusCode, responseBody);
+            }
+        };
 
         private readonly DockerClient _client;
 
@@ -55,7 +62,7 @@ internal ContainerOperations(DockerClient client)
             }
 
             var data = new JsonRequestContent<CreateContainerParameters>(parameters, this._client.JsonSerializer);
-            var response = await this._client.MakeRequestAsync(new[] { NoSuchContainerHandler }, HttpMethod.Post, "containers/create", qs, data, cancellationToken).ConfigureAwait(false);
+            var response = await this._client.MakeRequestAsync(new[] { NoSuchImageHandler }, HttpMethod.Post, "containers/create", qs, data, cancellationToken).ConfigureAwait(false);
             return this._client.JsonSerializer.DeserializeObject<CreateContainerResponse>(response.Body);
         }
 

test/Docker.DotNet.Tests/IContainerOperationsTests.cs

@@ -808,5 +808,17 @@ public async Task WaitContainerAsync_TokenIsCancelled_OperationCancelledExceptio
             Assert.InRange(stopWatch.Elapsed, delay.Subtract(tolerance), delay.Add(tolerance));
             Assert.True(waitContainerTask.IsCanceled);
         }
+
+        [Fact]
+        public async Task CreateImageAsync_NonexistantImage_ThrowsDockerImageNotFoundException()
+        {
+            var parameters = new CreateContainerParameters
+            {
+                Image = "no-such-image-ytfghbkufhresdhtrjygvb",
+            };
+            Func<Task> op = async () => await _dockerClient.Containers.CreateContainerAsync(parameters);
+
+            await Assert.ThrowsAsync<DockerImageNotFoundException>(op);
+        }
     }
 }