Skip to content

Could MarshaledString (and others) be made public? #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackoalan opened this issue Nov 12, 2020 · 1 comment
Closed

Could MarshaledString (and others) be made public? #152

jackoalan opened this issue Nov 12, 2020 · 1 comment

Comments

@jackoalan
Copy link
Contributor

Since there is a considerable portion of the raw API bindings that aren't implemented in the managed bindings, some raw calls are required in special cases. Many of the unimplemented raw calls accept string parameters (e.g. LLVM.AddModuleFlag), but since MarshaledString is internal, the application needs to reinvent this wheel within its own assembly.

@tannergooding
Copy link
Member

I think it would be better to just ensure the relevant overloads are exposed. I'm not completely against exposing MarshaledString, but just exposing things like AddModuleFlag on LLVMModuleRef seems like the overall better approach to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants