Skip to content

Commit 04afd94

Browse files
committed
Specifically, this merges [dc3950f from that repo](AArnott/Library.Template@dc3950f).
2 parents 4dfef95 + dc3950f commit 04afd94

File tree

10 files changed

+36
-13
lines changed

10 files changed

+36
-13
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Refer to https://hub.docker.com/_/microsoft-dotnet-sdk for available versions
2-
FROM mcr.microsoft.com/dotnet/sdk:9.0.303-noble@sha256:af75742bd2f6fd148504951b57a983bc410191729bf543eae467528d1bc175e5
2+
FROM mcr.microsoft.com/dotnet/sdk:9.0.304-noble@sha256:1f7ccf88e076bc1cb1ddbd81959fb55b886b01851b092867bb7a638435fa1f1f
33

44
# Installing mono makes `dotnet test` work without errors even for net472.
55
# But installing it takes a long time, so it's excluded by default.

.github/copilot-instructions.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Copilot instructions for this repository
2+
3+
## High level guidance
4+
5+
* Review the `CONTRIBUTING.md` file for instructions to build and test the software.
6+
* Set the `NBGV_GitEngine` environment variable to `Disabled` before running any `dotnet` or `msbuild` commands.
7+
8+
## Software Design
9+
10+
* Design APIs to be highly testable, and all functionality should be tested.
11+
* Avoid introducing binary breaking changes in public APIs of projects under `src` unless their project files have `IsPackable` set to `false`.
12+
13+
## Testing
14+
15+
* There should generally be one test project (under the `test` directory) per shipping project (under the `src` directory). Test projects are named after the project being tested with a `.Test` suffix.
16+
* Tests should use the Xunit testing framework.
17+
* Some tests are known to be unstable. When running tests, you should skip the unstable ones by running `dotnet test --filter "TestCategory!=FailsInCloudTest"`.
18+
19+
## Coding style
20+
21+
* Honor StyleCop rules and fix any reported build warnings *after* getting tests to pass.
22+
* In C# files, use namespace *statements* instead of namespace *blocks* for all new files.
23+
* Add API doc comments to all new public and internal members.

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
rid: win
3434

3535
steps:
36-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
36+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
3737
with:
3838
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3939
submodules: true
@@ -102,7 +102,7 @@ jobs:
102102
name: 📃 Docs
103103
runs-on: ubuntu-latest
104104
steps:
105-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
105+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
106106
- name: 🔗 Markup Link Checker (mlc)
107107
uses: becheran/mlc@18a06b3aa2901ca197de59c8b0b1f54fdba6b3fa # v1.0.0
108108
with:

.github/workflows/copilot-setup-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
# You can define any steps you want, and they will run before the agent starts.
2727
# If you do not check out your code, Copilot will do this for you.
2828
steps:
29-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
29+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
3030
with:
3131
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3232
- name: ⚙ Install prerequisites

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
url: ${{ steps.deployment.outputs.page_url }}
2626
runs-on: ubuntu-latest
2727
steps:
28-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
28+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
2929
with:
3030
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3131
submodules: true

.github/workflows/libtemplate-update.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
contents: write
1818
pull-requests: write
1919
steps:
20-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
20+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
2121
with:
2222
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
2323

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
Echo "runid=$runid" >> $env:GITHUB_OUTPUT
7575
7676
- name: 🔻 Download deployables artifacts
77-
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
77+
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5
7878
with:
7979
name: deployables-Linux
8080
path: ${{ runner.temp }}/deployables

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ Push the tag.
4949
When your repo is hosted by GitHub and you are using GitHub Actions, you should create a GitHub Release using the standard GitHub UI.
5050
Having previously used `nbgv tag` and pushing the tag will help you identify the precise commit and name to use for this release.
5151

52-
After publishing the release, the `.github\workflows\release.yml` workflow will be automatically triggered, which will:
52+
After publishing the release, the `.github/workflows/release.yml` workflow will be automatically triggered, which will:
5353

54-
1. Find the most recent `.github\workflows\build.yml` GitHub workflow run of the tagged release.
54+
1. Find the most recent `.github/workflows/build.yml` GitHub workflow run of the tagged release.
5555
1. Upload the `deployables` artifact from that workflow run to your GitHub Release.
5656
1. If you have `NUGET_API_KEY` defined as a secret variable for your repo or org, any nuget packages in the `deployables` artifact will be pushed to nuget.org.
5757

@@ -88,7 +88,7 @@ The best way to keep your repo in sync with Library.Template's evolving features
8888
```ps1
8989
git fetch
9090
git checkout origin/main
91-
.\tools\MergeFrom-Template.ps1
91+
./tools/MergeFrom-Template.ps1
9292
# resolve any conflicts, then commit the merge commit.
9393
git push origin -u HEAD
9494
```

Directory.Packages.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
</ItemGroup>
3333
<ItemGroup Label="Library.Template">
3434
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
35-
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.3" />
36-
<PackageVersion Include="xunit.v3" Version="3.0.0" />
35+
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.4" />
36+
<PackageVersion Include="xunit.v3" Version="3.0.1" />
3737
</ItemGroup>
3838
<ItemGroup>
3939
<!-- Put repo-specific GlobalPackageReference items in this group. -->

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "9.0.303",
3+
"version": "9.0.304",
44
"rollForward": "patch",
55
"allowPrerelease": false
66
}

0 commit comments

Comments
 (0)