Fix | TdsParser.ProcessSSPI clear receivedBuff array after negTokenResp retrieval

Dominik Schiener · Dominik Schiener · commit 1e68c5b5776b · 2024-04-09T20:43:29.000+02:00
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -25,6 +25,8 @@ internal void ProcessSSPI(int receivedLength)
                 throw SQL.SynchronousCallMayNotPend();
             }
 
+            receivedBuff.AsSpan(receivedLength, receivedBuff.Length - receivedLength).Clear();
+
             // allocate send buffer and initialize length
             byte[] rentedSendBuff = ArrayPool<byte>.Shared.Rent((int)_authenticationProvider!.MaxSSPILength);
             byte[] sendBuff = rentedSendBuff; // need to track these separately in case someone updates the ref parameter

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@ internal void ProcessSSPI(int receivedLength)`
`25`	`25`	`throw SQL.SynchronousCallMayNotPend();`
`26`	`26`	`}`
`27`	`27`
	`28`	`+ receivedBuff.AsSpan(receivedLength, receivedBuff.Length - receivedLength).Clear();`
	`29`	`+`
`28`	`30`	`// allocate send buffer and initialize length`
`29`	`31`	`byte[] rentedSendBuff = ArrayPool<byte>.Shared.Rent((int)_authenticationProvider!.MaxSSPILength);`
`30`	`32`	`byte[] sendBuff = rentedSendBuff; // need to track these separately in case someone updates the ref parameter`