User Story 34145: Tidy up Bulk Copy unmatched column name work

- Fixed SNI reflection failures when running in NetFX.

Author: paulmedynski

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Common/InternalConnectionWrapper.cs

@@ -126,20 +126,25 @@ public void KillConnection()
         {
             object tdsParser = ConnectionHelper.GetParser(_internalConnection);
             object stateObject = TdsParserHelper.GetStateObject(tdsParser);
-            object sessionHandle = TdsParserStateObjectHelper.GetSessionHandle(stateObject);
 
-            Assembly systemDotData = Assembly.Load(new AssemblyName(typeof(SqlConnection).GetTypeInfo().Assembly.FullName));
-            Type sniHandleType = systemDotData.GetType("Microsoft.Data.SqlClient.SNI.SNIHandle");
-            MethodInfo killConn = sniHandleType.GetMethod("KillConnection");
+            Assembly assembly = Assembly.Load(new AssemblyName(typeof(SqlConnection).GetTypeInfo().Assembly.FullName));
+            Type sniHandleType = assembly.GetType("Microsoft.Data.SqlClient.SNI.SNIHandle");
 
-            if (killConn != null)
+            MethodInfo killConn = null;
+            if (sniHandleType is not null)
             {
-                killConn.Invoke(sessionHandle, null);
+                killConn = sniHandleType.GetMethod("KillConnection");
             }
-            else
+            
+            if (killConn is null)
             {
                 throw new InvalidOperationException("Error: Could not find SNI KillConnection test hook. This operation is only supported in debug builds.");
             }
+                
+            killConn.Invoke(
+                TdsParserStateObjectHelper.GetSessionHandle(stateObject),
+                null);
+
             // Ensure kill occurs outside of check connection window
             Thread.Sleep(100);
         }

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Common/SystemDataInternals/TdsParserStateObjectHelper.cs

@@ -4,20 +4,61 @@
 
 using System;
 using System.Reflection;
+using Xunit;
 
 namespace Microsoft.Data.SqlClient.ManualTesting.Tests.SystemDataInternals
 {
     internal static class TdsParserStateObjectHelper
     {
-        private static readonly Assembly s_systemDotData = typeof(Microsoft.Data.SqlClient.SqlConnection).GetTypeInfo().Assembly;
-        private static readonly Type s_tdsParserStateObject = s_systemDotData.GetType("Microsoft.Data.SqlClient.TdsParserStateObject");
-        private static readonly FieldInfo s_forceAllPends = s_tdsParserStateObject.GetField("s_forceAllPends", BindingFlags.Static | BindingFlags.NonPublic);
-        private static readonly FieldInfo s_skipSendAttention = s_tdsParserStateObject.GetField("s_skipSendAttention", BindingFlags.Static | BindingFlags.NonPublic);
-        private static readonly FieldInfo s_forceSyncOverAsyncAfterFirstPend = s_tdsParserStateObject.GetField("s_forceSyncOverAsyncAfterFirstPend", BindingFlags.Static | BindingFlags.NonPublic);
-        private static readonly FieldInfo s_failAsyncPends = s_tdsParserStateObject.GetField("s_failAsyncPends", BindingFlags.Static | BindingFlags.NonPublic);
-        private static readonly FieldInfo s_forcePendingReadsToWaitForUser = s_tdsParserStateObject.GetField("s_forcePendingReadsToWaitForUser", BindingFlags.Static | BindingFlags.NonPublic);
-        private static readonly Type s_tdsParserStateObjectManaged = s_systemDotData.GetType("Microsoft.Data.SqlClient.SNI.TdsParserStateObjectManaged");
-        private static readonly FieldInfo s_tdsParserStateObjectManagedSessionHandle = s_tdsParserStateObjectManaged.GetField("_sessionHandle", BindingFlags.Instance | BindingFlags.NonPublic);
+        private static readonly FieldInfo s_forceAllPends;
+        private static readonly FieldInfo s_skipSendAttention;
+        private static readonly FieldInfo s_forceSyncOverAsyncAfterFirstPend;
+        private static readonly FieldInfo s_failAsyncPends;
+        private static readonly FieldInfo s_forcePendingReadsToWaitForUser;
+        private static readonly Type s_tdsParserStateObjectManaged;
+        private static readonly FieldInfo s_tdsParserStateObjectManagedSessionHandle;
+
+        static TdsParserStateObjectHelper()
+        {
+            Assembly assembly = typeof(Microsoft.Data.SqlClient.SqlConnection).GetTypeInfo().Assembly;
+            Assert.True(assembly is not null, nameof(assembly));
+
+            Type tdsParserStateObject = assembly.GetType("Microsoft.Data.SqlClient.TdsParserStateObject");
+            Assert.True(tdsParserStateObject is not null, nameof(tdsParserStateObject));
+
+            s_forceAllPends = tdsParserStateObject.GetField("s_forceAllPends", BindingFlags.Static | BindingFlags.NonPublic);
+            Assert.True(s_forceAllPends is not null, nameof(s_forceAllPends));
+
+            s_skipSendAttention = tdsParserStateObject.GetField("s_skipSendAttention", BindingFlags.Static | BindingFlags.NonPublic);
+            Assert.True(s_skipSendAttention is not null, nameof(s_skipSendAttention));
+
+            s_forceSyncOverAsyncAfterFirstPend = tdsParserStateObject.GetField("s_forceSyncOverAsyncAfterFirstPend", BindingFlags.Static | BindingFlags.NonPublic);
+            Assert.True(s_forceSyncOverAsyncAfterFirstPend is not null, nameof(s_forceSyncOverAsyncAfterFirstPend));
+
+            s_failAsyncPends = tdsParserStateObject.GetField("s_failAsyncPends", BindingFlags.Static | BindingFlags.NonPublic);
+            Assert.True(s_failAsyncPends is not null, nameof(s_failAsyncPends));
+
+            s_forcePendingReadsToWaitForUser = tdsParserStateObject.GetField("s_forcePendingReadsToWaitForUser", BindingFlags.Static | BindingFlags.NonPublic);
+            Assert.True(s_forcePendingReadsToWaitForUser is not null, nameof(s_forcePendingReadsToWaitForUser));
+
+            // These managed SNI handles are allowed to be null, since they
+            // won't exist in .NET Framework builds.
+            s_tdsParserStateObjectManaged =
+                assembly.GetType("Microsoft.Data.SqlClient.SNI.TdsParserStateObjectManaged");
+            s_tdsParserStateObjectManagedSessionHandle = null;
+            if (s_tdsParserStateObjectManaged is not null)
+            {
+                s_tdsParserStateObjectManagedSessionHandle =
+                    s_tdsParserStateObjectManaged.GetField(
+                        "_sessionHandle",
+                        BindingFlags.Instance | BindingFlags.NonPublic);
+                // If we have the managed SNI type, we must have the session
+                // handle field.
+                Assert.True(
+                    s_tdsParserStateObjectManagedSessionHandle is not null,
+                    nameof(s_tdsParserStateObjectManagedSessionHandle));
+            }
+        }
 
         internal static bool ForceAllPends
         {
@@ -49,17 +90,20 @@ internal static bool FailAsyncPends
             set { s_failAsyncPends.SetValue(null, value); }
         }
 
-        private static void VerifyObjectIsTdsParserStateObject(object stateObject)
+        internal static object GetSessionHandle(object stateObject)
         {
             if (stateObject == null)
+            {
                 throw new ArgumentNullException(nameof(stateObject));
-            if (!s_tdsParserStateObjectManaged.IsInstanceOfType(stateObject))
+            }
+            if (s_tdsParserStateObjectManaged is null)
+            {
+                throw new InvalidOperationException("This method is not supported on this platform.");
+            }
+            if (! s_tdsParserStateObjectManaged.IsInstanceOfType(stateObject))
+            {
                 throw new ArgumentException("Object provided was not a TdsParserStateObjectManaged", nameof(stateObject));
-        }
-
-        internal static object GetSessionHandle(object stateObject)
-        {
-            VerifyObjectIsTdsParserStateObject(stateObject);
+            }
             return s_tdsParserStateObjectManagedSessionHandle.GetValue(stateObject);
         }
     }