Use official name for US English locale - #4646
Open
priyankatiwari08 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only correction is accurate and introduces no behavioral changes.
Pull request overview
Corrects the LCID 1033 documentation sample to use the official Windows locale name.
Changes:
- Replaces
English - United StateswithEnglish (United States). - Leaves runtime behavior and APIs unchanged.
File summaries
| File | Description |
|---|---|
doc/snippets/Microsoft.Data.SqlClient/SqlParameter.xml |
Corrects the US English locale comment. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulmedynski
approved these changes
Sep 4, 2026
cheenamalhotra
approved these changes
Sep 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4646 +/- ##
==========================================
- Coverage 65.92% 63.70% -2.22%
==========================================
Files 290 284 -6
Lines 44987 67980 +22993
==========================================
+ Hits 29656 43305 +13649
- Misses 15331 24675 +9344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
English (United States)Current Languageconnection-string handling unchangedAzure DevOps task: 45863 - Review Language Names
Parent story: 45850 - Global Readiness for GA Release 7.1
Review evidence
The requirement is applicable rather than N/A because a shipped documentation sample displayed LCID 1033 as
English - United States. Microsoft Windows documentation names this localeEnglish (United States).The broader review found no other curated language or locale name mismatch.
Current Languageis an opaque SQL Server language-record name or alias passed through to the TDS login, LCID tables contain numeric protocol mappings, and satellite resource paths use technical culture identifiers.Checklist