[Mono.Android.dll] Fix [SupportedOSPlatform] warnings. (#8247)

jpobst · web-flow · commit 0c5b60d50fc6 · 2023-08-10T15:32:39.000-04:00
Fixes: #7590 Fix the remaining `[SupportedOSPlatform]` warnings in manually bound code. Other issues we were previously seeing appear to have been a bug in earlier .NET 8 previews. In the simple cases, we just needed to add `[SupportedOSPlatform]` to our hand-written methods. For more complicated cases, we resolve the remaining CA1416 and CA1422 warnings by using `[SuppressMessage]`. Rationale: The constructors for [`java.lang.Boolean(boolean)`][0], [`java.lang.Integer(int)`][2], etc., were marked as `@Deprecated` in API-33, with a suggestion to instead use [`Booleal.valueOf(boolean)`][1], [`Integer.valueOf(int)`][3], etc. We *cannot* follow this advice in multiple places of our infrastructure, due to a desire to reduce JNI Global Reference (GREF) usage and preserve thread safety. Imagine that two threads execute the following code: using (var val = Java.Lang.Integer.ValueOf(42)) { val.FloatValue(); } Because we attempt to preserve object identity -- if multiple Java calls of `Integer.valueOf(42)` return the same instance, then multiple C# calls of `Integer.ValueOf(42)` should likewise return the same instance -- we may be dealing with mutable shared state! 1. Thread 1: calls C# `Integer.ValueOf(42)`, calls Java `Integer.valueOf(42)`, `Java.Lang.Integer` wrapper instance created and registered. 2. Thread 1: calls `val.FloatValue()` 3. Thread 2: calls `Integer.ValueOf(42)`, gets wrapper instance created in (1) 4. Thread 1: calls `val.Dispose()` 5. Thread 2: calls `val.FloatValue()`. This throws an `ObjectDisposedException`, because of (4). We thus have a conundrum: if we replace all usage of the e.g. `Integer(int)` constructor with calls to `Integer.ValueOf(int)`, *we can no longer* call `.Dispose()` on the value. This willl increase GREF usage, *but could be an overall improvement* as it may also result in fewer Java-side `Integer` instances being created. Without additional testing and microbenchmarks, it's hard to say which is actually "better". In the absense of such a micobenchmark, resolve some of the CA1416 and CA1422 warnings by using `[SuppressMessage]`. [0]: https://developer.android.com/reference/java/lang/Boolean#Boolean(boolean) [1]: https://developer.android.com/reference/java/lang/Boolean#valueOf(boolean) [2]: https://developer.android.com/reference/java/lang/Integer#Integer(int) [3]: https://developer.android.com/reference/java/lang/Integer#valueOf(int)
diff --git a/src/Mono.Android/Android.Content/ContentValues.cs b/src/Mono.Android/Android.Content/ContentValues.cs
@@ -119,6 +119,7 @@ public short GetAsShort (string key)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Boolean_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Boolean;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, bool value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Boolean_ == IntPtr.Zero)
@@ -134,6 +135,7 @@ public void Put (string key, bool value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Byte_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Byte;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, sbyte value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Byte_ == IntPtr.Zero)
@@ -149,6 +151,7 @@ public void Put (string key, sbyte value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Short_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Short;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, short value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Short_ == IntPtr.Zero)
@@ -164,6 +167,7 @@ public void Put (string key, short value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Integer_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Integer;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, int value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Integer_ == IntPtr.Zero)
@@ -179,6 +183,7 @@ public void Put (string key, int value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Long_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Long;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, long value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Long_ == IntPtr.Zero)
@@ -194,6 +199,7 @@ public void Put (string key, long value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Float_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Float;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, float value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Float_ == IntPtr.Zero)
@@ -209,6 +215,7 @@ public void Put (string key, float value)
 
 		static IntPtr id_put_Ljava_lang_String_Ljava_lang_Double_;
 		[Register ("put", "(Ljava/lang/String;Ljava/lang/Double;)V", "")]
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public void Put (string key, double value)
 		{
 			if (id_put_Ljava_lang_String_Ljava_lang_Double_ == IntPtr.Zero)
diff --git a/src/Mono.Android/Android.Content/Context.cs b/src/Mono.Android/Android.Content/Context.cs
@@ -20,9 +20,11 @@ public void StartActivity (Type type)
 
 #if ANDROID_34
 		// Add correctly enumified overloads
+		[global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android26.0")]
 		public Intent? RegisterReceiver (BroadcastReceiver? receiver, IntentFilter? filter, ReceiverFlags flags)
 			=> RegisterReceiver (receiver, filter, (ActivityFlags)flags);
 
+		[global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android26.0")]
 		public Intent? RegisterReceiver (BroadcastReceiver? receiver, IntentFilter? filter, string? broadcastPermission, Handler? scheduler, ReceiverFlags flags)
 			=> RegisterReceiver (receiver, filter, broadcastPermission, scheduler, (ActivityFlags)flags);
 #endif
diff --git a/src/Mono.Android/Android.Media/AudioTrack.cs b/src/Mono.Android/Android.Media/AudioTrack.cs
@@ -4,12 +4,14 @@ namespace Android.Media
 {
 	public partial class AudioTrack
 	{
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android26.0")]
 		[Obsolete ("ChannelConfiguration is obsolete. Please use another overload with ChannelOut instead")]
 		public AudioTrack ([global::Android.Runtime.GeneratedEnum] Android.Media.Stream streamType, int sampleRateInHz, [global::Android.Runtime.GeneratedEnum] Android.Media.ChannelConfiguration channelConfig, [global::Android.Runtime.GeneratedEnum] Android.Media.Encoding audioFormat, int bufferSizeInBytes, [global::Android.Runtime.GeneratedEnum] Android.Media.AudioTrackMode mode)
 			: this (streamType, sampleRateInHz, (ChannelOut) (int) channelConfig, audioFormat, bufferSizeInBytes, mode)
 		{
 		}
 #if ANDROID_9
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android26.0")]
 		[Obsolete ("ChannelConfiguration is obsolete. Please use another overload with ChannelOut instead")]
 		public AudioTrack ([global::Android.Runtime.GeneratedEnum] Android.Media.Stream streamType, int sampleRateInHz, [global::Android.Runtime.GeneratedEnum] Android.Media.ChannelConfiguration channelConfig, [global::Android.Runtime.GeneratedEnum] Android.Media.Encoding audioFormat, int bufferSizeInBytes, [global::Android.Runtime.GeneratedEnum] Android.Media.AudioTrackMode mode, int sessionId)
 			: this (streamType, sampleRateInHz, (ChannelOut) (int) channelConfig, audioFormat, bufferSizeInBytes, mode, sessionId)
diff --git a/src/Mono.Android/Android.OS/AsyncTask.cs b/src/Mono.Android/Android.OS/AsyncTask.cs
@@ -7,6 +7,7 @@
 
 namespace Android.OS {
 
+	[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android30.0")]
 	[Register ("android/os/AsyncTask", DoNotGenerateAcw=true)]
 	public abstract class AsyncTask<TParams, TProgress, TResult> : AsyncTask {
 
diff --git a/src/Mono.Android/Android.OS/Handler.cs b/src/Mono.Android/Android.OS/Handler.cs
@@ -5,6 +5,7 @@ namespace Android.OS {
 
 	public partial class Handler {
 
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android30.0")]
 		public Handler (Action<Message> handler)
 			: this (new ActionHandlerCallback (handler))
 		{
diff --git a/src/Mono.Android/Android.OS/Vibrator.cs b/src/Mono.Android/Android.OS/Vibrator.cs
@@ -6,6 +6,7 @@ namespace Android.OS {
 
 	public partial class Vibrator {
 
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android31.0", "Use VibratorManager to retrieve the default system vibrator.")]
 		public static Vibrator? FromContext (Context context)
 		{
 			return context.GetSystemService (Context.VibratorService!) as Vibrator;
diff --git a/src/Mono.Android/Android.Runtime/AndroidEnvironment.cs b/src/Mono.Android/Android.Runtime/AndroidEnvironment.cs
@@ -237,6 +237,7 @@ static void NotifyTimeZoneChanged ()
 		//
 		//  Rationale
 		//     No longer called by the indicated caller, however we keep it for backward compatibility.
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android31.0")]
 		static void GetDisplayDPI (out float x_dpi, out float y_dpi)
 		{
 			var wm = Application.Context.GetSystemService (Context.WindowService).JavaCast <IWindowManager> ();
diff --git a/src/Mono.Android/Android.Runtime/JavaObject.cs b/src/Mono.Android/Android.Runtime/JavaObject.cs
@@ -5,6 +5,7 @@ namespace Android.Runtime {
 	[Register ("mono/android/runtime/JavaObject")]
 	internal sealed class JavaObject : Java.Lang.Object {
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static IntPtr GetHandle (object obj)
 		{
 			if (obj == null)
diff --git a/src/Mono.Android/Android.Telecom/InCallService.cs b/src/Mono.Android/Android.Telecom/InCallService.cs
@@ -7,6 +7,7 @@ public abstract partial class InCallService : Android.App.Service
 	{
 #if ANDROID_23
 		[Obsolete ("Incorrect enum parameter, use the overload that takes a CallAudioRoute parameter instead.")]
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android34.0")]
 		[global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android23.0")]
 		public void SetAudioRoute ([global::Android.Runtime.GeneratedEnum] Android.Telecom.VideoQuality route)
 		{
diff --git a/src/Mono.Android/Android.Telephony/CellInfo.cs b/src/Mono.Android/Android.Telephony/CellInfo.cs
@@ -11,20 +11,23 @@ public partial class CellInfo {
 
 		static Delegate? cb_getCellIdentity;
 #pragma warning disable 0169
+		[global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]
 		static Delegate GetGetCellIdentityHandler ()
 		{
 			if (cb_getCellIdentity == null)
 				cb_getCellIdentity = JNINativeWrapper.CreateDelegate ((Func<IntPtr, IntPtr, IntPtr>) n_GetCellIdentity);
 			return cb_getCellIdentity;
 		}
 
+		[global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]
 		static IntPtr n_GetCellIdentity (IntPtr jnienv, IntPtr native__this)
 		{
 			var __this = global::Java.Lang.Object.GetObject<Android.Telephony.CellInfo> (jnienv, native__this, JniHandleOwnership.DoNotTransfer)!;
 			return JNIEnv.ToLocalJniHandle (__this.CellIdentity);
 		}
 #pragma warning restore 0169
 
+		[global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]
 		public unsafe virtual Android.Telephony.CellIdentity CellIdentity {
 			// Metadata.xml XPath method reference: path="/api/package[@name='android.telephony']/class[@name='CellInfo']/method[@name='getCellIdentity' and count(parameter)=0]"
 			[Register ("getCellIdentity", "()Landroid/telephony/CellIdentity;", "GetGetCellIdentityHandler", ApiSince = 30)]
diff --git a/src/Mono.Android/Android.Views/View.cs b/src/Mono.Android/Android.Views/View.cs
@@ -77,6 +77,7 @@ public void UnscheduleDrawable (Android.Graphics.Drawables.Drawable who, Action
 
 #if ANDROID_11
 		[Obsolete ("Please Use DispatchSystemUiVisibilityChanged(SystemUiFlags)")]
+		[global::System.Runtime.Versioning.ObsoletedOSPlatform ("android30.0")]
 		public void DispatchSystemUiVisibilityChanged (int visibility)
 		{
 			DispatchSystemUiVisibilityChanged ((SystemUiFlags) visibility);
diff --git a/src/Mono.Android/Java.Interop/JavaConvert.cs b/src/Mono.Android/Java.Interop/JavaConvert.cs
@@ -274,6 +274,7 @@ static Func<IntPtr, JniHandleOwnership, object> GetJniHandleConverterForType ([D
 			return Convert.ChangeType (value, targetType, CultureInfo.InvariantCulture);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		static Dictionary<Type, Func<object, IJavaObject>> JavaObjectConverters = new Dictionary<Type, Func<object, IJavaObject>>() {
 			{ typeof (bool),   value => new Java.Lang.Boolean ((bool) value) },
 			{ typeof (byte),   value => new Java.Lang.Byte ((sbyte) (byte) value) },
@@ -306,6 +307,7 @@ static Func<IntPtr, JniHandleOwnership, object> GetJniHandleConverterForType ([D
 			return new Android.Runtime.JavaObject (value);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		static Dictionary<Type, Func<object, IntPtr>> LocalJniHandleConverters = new Dictionary<Type, Func<object, IntPtr>> {
 			{ typeof (bool),   value => {
 				using (var v = new Java.Lang.Boolean ((bool) value))
diff --git a/src/Mono.Android/Java.Interop/TypeManager.cs b/src/Mono.Android/Java.Interop/TypeManager.cs
@@ -8,7 +8,6 @@
 using Java.Interop.Tools.TypeNameMappings;
 
 using Android.Runtime;
-using System.Diagnostics.CodeAnalysis;
 
 namespace Java.Interop {
 
diff --git a/src/Mono.Android/Java.Lang/Object.cs b/src/Mono.Android/Java.Lang/Object.cs
@@ -316,6 +316,7 @@ protected void SetHandle (IntPtr value, JniHandleOwnership transfer)
 			return new Java.Lang.Object (JNIEnv.NewArray (value), JniHandleOwnership.TransferLocalRef);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (bool value)
 		{
 			return new Java.Lang.Boolean (value);
@@ -327,11 +328,13 @@ public static implicit operator Java.Lang.Object (byte value)
 			throw new InvalidOperationException ("Should not be reached");
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (sbyte value)
 		{
 			return new Java.Lang.Byte (value);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (char value)
 		{
 			return new Java.Lang.Character (value);
@@ -343,6 +346,7 @@ public static implicit operator Java.Lang.Object (uint value)
 			throw new InvalidOperationException ("Should not be reached");
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (int value)
 		{
 			return new Java.Lang.Integer (value);
@@ -354,16 +358,19 @@ public static implicit operator Java.Lang.Object (ulong value)
 			throw new InvalidOperationException ("Should not be reached");
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (long value)
 		{
 			return new Java.Lang.Long (value);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (float value)
 		{
 			return new Java.Lang.Float (value);
 		}
 
+		[System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]
 		public static implicit operator Java.Lang.Object (double value)
 		{
 			return new Java.Lang.Double (value);
diff --git a/src/Mono.Android/Mono.Android.csproj b/src/Mono.Android/Mono.Android.csproj
@@ -42,10 +42,6 @@
     <NoWarn>$(NoWarn);CS1572;CS1573;CS1574;CS1584;CS1587;CS1591;CS1658;</NoWarn>
   </PropertyGroup>
 
-  <PropertyGroup Condition=" '$(_EnableCodeAnalyzerPlatformWarnings)' == '' ">
-    <NoWarn>$(NoWarn);CA1422;CA1416</NoWarn>
-  </PropertyGroup>
-
   <ItemGroup>
     <AdditionalFiles Include="PublicAPI\API-$(AndroidApiLevel)\PublicAPI.Shipped.txt" />
     <AdditionalFiles Include="PublicAPI\API-$(AndroidApiLevel)\PublicAPI.Unshipped.txt" />

Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,14 @@ namespace Android.Media`
`4`	`4`	`{`
`5`	`5`	`public partial class AudioTrack`
`6`	`6`	`{`
	`7`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android26.0")]`
`7`	`8`	`[Obsolete ("ChannelConfiguration is obsolete. Please use another overload with ChannelOut instead")]`
`8`	`9`	`public AudioTrack ([global::Android.Runtime.GeneratedEnum] Android.Media.Stream streamType, int sampleRateInHz, [global::Android.Runtime.GeneratedEnum] Android.Media.ChannelConfiguration channelConfig, [global::Android.Runtime.GeneratedEnum] Android.Media.Encoding audioFormat, int bufferSizeInBytes, [global::Android.Runtime.GeneratedEnum] Android.Media.AudioTrackMode mode)`
`9`	`10`	`: this (streamType, sampleRateInHz, (ChannelOut) (int) channelConfig, audioFormat, bufferSizeInBytes, mode)`
`10`	`11`	`{`
`11`	`12`	`}`
`12`	`13`	`#if ANDROID_9`
	`14`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android26.0")]`
`13`	`15`	`[Obsolete ("ChannelConfiguration is obsolete. Please use another overload with ChannelOut instead")]`
`14`	`16`	`public AudioTrack ([global::Android.Runtime.GeneratedEnum] Android.Media.Stream streamType, int sampleRateInHz, [global::Android.Runtime.GeneratedEnum] Android.Media.ChannelConfiguration channelConfig, [global::Android.Runtime.GeneratedEnum] Android.Media.Encoding audioFormat, int bufferSizeInBytes, [global::Android.Runtime.GeneratedEnum] Android.Media.AudioTrackMode mode, int sessionId)`
`15`	`17`	`: this (streamType, sampleRateInHz, (ChannelOut) (int) channelConfig, audioFormat, bufferSizeInBytes, mode, sessionId)`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ namespace Android.OS {`
`5`	`5`
`6`	`6`	`public partial class Handler {`
`7`	`7`
	`8`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android30.0")]`
`8`	`9`	`public Handler (Action<Message> handler)`
`9`	`10`	`: this (new ActionHandlerCallback (handler))`
`10`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ namespace Android.OS {`
`6`	`6`
`7`	`7`	`public partial class Vibrator {`
`8`	`8`
	`9`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android31.0", "Use VibratorManager to retrieve the default system vibrator.")]`
`9`	`10`	`public static Vibrator? FromContext (Context context)`
`10`	`11`	`{`
`11`	`12`	`return context.GetSystemService (Context.VibratorService!) as Vibrator;`
Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ static void NotifyTimeZoneChanged ()`
`237`	`237`	`//`
`238`	`238`	`// Rationale`
`239`	`239`	`// No longer called by the indicated caller, however we keep it for backward compatibility.`
	`240`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android31.0")]`
`240`	`241`	`static void GetDisplayDPI (out float x_dpi, out float y_dpi)`
`241`	`242`	`{`
`242`	`243`	`var wm = Application.Context.GetSystemService (Context.WindowService).JavaCast <IWindowManager> ();`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ namespace Android.Runtime {`
`5`	`5`	`[Register ("mono/android/runtime/JavaObject")]`
`6`	`6`	`internal sealed class JavaObject : Java.Lang.Object {`
`7`	`7`
	`8`	`+ [System.Diagnostics.CodeAnalysis.SuppressMessage ("Interoperability", "CA1422:Validate platform compatibility", Justification = "Suggested replacement uses instance sharing")]`
`8`	`9`	`public static IntPtr GetHandle (object obj)`
`9`	`10`	`{`
`10`	`11`	`if (obj == null)`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ public abstract partial class InCallService : Android.App.Service`
`7`	`7`	`{`
`8`	`8`	`#if ANDROID_23`
`9`	`9`	`[Obsolete ("Incorrect enum parameter, use the overload that takes a CallAudioRoute parameter instead.")]`
	`10`	`+ [global::System.Runtime.Versioning.ObsoletedOSPlatform ("android34.0")]`
`10`	`11`	`[global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android23.0")]`
`11`	`12`	`public void SetAudioRoute ([global::Android.Runtime.GeneratedEnum] Android.Telecom.VideoQuality route)`
`12`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,20 +11,23 @@ public partial class CellInfo {`
`11`	`11`
`12`	`12`	`static Delegate? cb_getCellIdentity;`
`13`	`13`	`#pragma warning disable 0169`
	`14`	`+ [global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]`
`14`	`15`	`static Delegate GetGetCellIdentityHandler ()`
`15`	`16`	`{`
`16`	`17`	`if (cb_getCellIdentity == null)`
`17`	`18`	`cb_getCellIdentity = JNINativeWrapper.CreateDelegate ((Func<IntPtr, IntPtr, IntPtr>) n_GetCellIdentity);`
`18`	`19`	`return cb_getCellIdentity;`
`19`	`20`	`}`
`20`	`21`
	`22`	`+ [global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]`
`21`	`23`	`static IntPtr n_GetCellIdentity (IntPtr jnienv, IntPtr native__this)`
`22`	`24`	`{`
`23`	`25`	`var __this = global::Java.Lang.Object.GetObject<Android.Telephony.CellInfo> (jnienv, native__this, JniHandleOwnership.DoNotTransfer)!;`
`24`	`26`	`return JNIEnv.ToLocalJniHandle (__this.CellIdentity);`
`25`	`27`	`}`
`26`	`28`	`#pragma warning restore 0169`
`27`	`29`
	`30`	`+ [global::System.Runtime.Versioning.SupportedOSPlatform ("android28.0")]`
`28`	`31`	`public unsafe virtual Android.Telephony.CellIdentity CellIdentity {`
`29`	`32`	`// Metadata.xml XPath method reference: path="/api/package[@name='android.telephony']/class[@name='CellInfo']/method[@name='getCellIdentity' and count(parameter)=0]"`
`30`	`33`	`[Register ("getCellIdentity", "()Landroid/telephony/CellIdentity;", "GetGetCellIdentityHandler", ApiSince = 30)]`