Skip to content

Commit ef8257d

Browse files
committed
Build tweaks to make progress easier
Some of those changes will stay, most will go. Makes it possible to move foreward for now without having CoreCLR packs for all the targets. Only arm64 supported atm
1 parent d4012bc commit ef8257d

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

Configuration.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,6 @@
223223

224224
<!-- TEMPORARY: to be removed once this PR is ready to be merged -->
225225
<PropertyGroup>
226-
<_LocalClrDirectory>$(AndroidToolchainDirectory)\clr</_LocalClrDirectory>
226+
<_LocalClrDirectory Condition=" Exists('$(AndroidToolchainDirectory)\clr') ">$(AndroidToolchainDirectory)\clr</_LocalClrDirectory>
227227
</PropertyGroup>
228228
</Project>

build-tools/create-packs/Microsoft.Android.Runtime.proj

+7-6
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,13 @@ projects that use the Microsoft.Android framework in .NET 6+.
6161
</ItemGroup>
6262

6363
<ItemGroup Condition=" '$(AndroidRuntime)' != 'NativeAOT' ">
64-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libc.so" />
65-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libdl.so" />
66-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\liblog.so" />
67-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libm.so" />
68-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libz.so" />
69-
<_AndroidRuntimePackAssets Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libarchive-dso-stub.so" />
64+
<!-- TODO: the Exists() checks must go away once we build CoreCLR host for all the targets -->
65+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libc.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libc.so" />
66+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libdl.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libdl.so" />
67+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\liblog.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\liblog.so" />
68+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libm.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libm.so" />
69+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libz.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libz.so" />
70+
<_AndroidRuntimePackAssets Condition=" Exists('$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libarchive-dso-stub.so') " Include="$(NativeRuntimeOutputRootDir)$(_RuntimeFlavorDirName)\$(AndroidRID)\libarchive-dso-stub.so" />
7071
</ItemGroup>
7172

7273
<ItemGroup>

src/native/clr/host/CMakeLists.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ macro(lib_target_options TARGET_NAME)
106106
${TARGET_NAME}
107107
SYSTEM PRIVATE
108108
${SYSROOT_CXX_INCLUDE_DIR}
109-
${MONO_RUNTIME_INCLUDE_DIR}
109+
${RUNTIME_INCLUDE_DIR}
110+
${TEMP_MONO_RUNTIME_INCLUDE_DIR}
110111
${NATIVE_TRACING_INCLUDE_DIRS}
111112
${LIBUNWIND_INCLUDE_DIRS}
112113
)

0 commit comments

Comments
 (0)