-
Notifications
You must be signed in to change notification settings - Fork 564
Fix outdated contents in WorkloadDependencies.json #10627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@copilot try again |
Co-authored-by: jonathanpeppers <[email protected]>
Contributor
Author
Copilot
AI
changed the title
[WIP] Fix outdated contents in WorkloadDependencies.json
Fix outdated contents in WorkloadDependencies.json
Dec 5, 2025
jonathanpeppers
approved these changes
Dec 5, 2025
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me, but we should check CI is green. (it's ongoing)
grendello
approved these changes
Dec 8, 2025
Co-authored-by: jonathanpeppers <[email protected]>
Member
|
I see correct values now: {
"desc": "Android SDK Platform 36",
"sdkPackage": {
"id": "platforms;android-36"
},
"optional": "false"
}, |
Member
|
This file is unused by our build, so not going to rerun some of the flaky test lanes. Merging. |
jonathanpeppers
added a commit
that referenced
this pull request
Dec 8, 2025
Fixes: #10596 - Updated the local file path from `AndroidManifestFeed_d17.12.xml` to `AndroidManifestFeed_d18.0.xml` - Updated the fallback URL from `https://aka.ms/AndroidManifestFeed/d17-12` to `https://aka.ms/AndroidManifestFeed/d18-0` The Dev18 (`d18-0`) feed contains the `android-36` and `android-36.1` platform entries needed for .NET 10. Co-authored-by: Jonathan Peppers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Android manifest feed reference in
WorkloadDependencies.projfromd17-12to Dev18 (d18-0) to fix outdated Android SDK versions in the generatedWorkloadDependencies.json.Problem
The
WorkloadDependencies.jsonfile was being generated with outdated Android SDK versions:build-tools;35.0.0instead of 36.xplatforms;android-35instead of android-36Root Cause
The feed URL in
tools/workload-dependencies/WorkloadDependencies.projwas pointing tod17-12, which doesn't contain SDK 36 entries.Changes Made
AndroidManifestFeed_d17.12.xmltoAndroidManifestFeed_d18.0.xmlhttps://aka.ms/AndroidManifestFeed/d17-12tohttps://aka.ms/AndroidManifestFeed/d18-0The Dev18 (
d18-0) feed contains theandroid-36andandroid-36.1platform entries needed for .NET 10.Original prompt
WorkloadDependencies.jsonhas wrong contents #10596💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.