Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateNativeVersionFile should only run when the TargetOS is windows-like #15496

Open
steveisok opened this issue Feb 7, 2025 · 0 comments

Comments

@steveisok
Copy link
Member

The condition below will cause the target to run on Windows regardless if you're cross compiling or not.

<PropertyGroup Condition="'$(OS)' == 'Windows_NT'">

To date, that's been ok because building on windows has only dealt with windows-like targets. dotnet/runtime#112256 enables building for android on windows and so the condition above no longer holds.

We should utilize the Unified Build output controls and fall back to the HostOS if the TargetOS is not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant