-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UTC timestamp display option #7602
base: main
Are you sure you want to change the base?
Add UTC timestamp display option #7602
Conversation
How often do people prefer UTC instead of local if it's available? Is there the notion of dashboard configuration that could decide what is the format (UTC, local to server, local to user, ... any other specific one). My own preference would be a user setting (stored in cookies, local storage?) if not an app one (code, app settings?) instead of a per-link action. |
We could do that, not trivially
It is a user setting persisted, not per-resource. |
Ok I’ve decided to turn this into a select |
I think it is confusing UI to have two options for showing timestamps. Here is what I think it should be:
Does that make sense? I think the menu control we're using here already supports these features: seperators, disabling items |
[Parameter] | ||
public bool ShowTimestamp { get; set; } | ||
public TimestampDisplayMode TimestampDisplayMode { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be different bool parameters:
ShowTimestamp
IsTimestampUtc
Description
Unsure about the specific icon, or whether it should be turned into a select and promoted to the toolbar. @JamesNK thoughts?
(hidden timestamps)
![image](https://private-user-images.githubusercontent.com/20359921/413038531-bfc81f66-3116-4d16-81e0-9b77d8821bb1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjY2MzMsIm5iZiI6MTczOTY2NjMzMywicGF0aCI6Ii8yMDM1OTkyMS80MTMwMzg1MzEtYmZjODFmNjYtMzExNi00ZDE2LTgxZTAtOWI3N2Q4ODIxYmIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAwMzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3ZjdkYzdjNGZlYjEyMThkNGI3YTIwNjI5NzllOGZjYmJjYTZiMzNjNGU3ZDA1YmIzM2Q5ZDg1MjliOTc3NmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EqOsDxUR0z29GnVX_Qis18RLy2vtoNeYLCxtJD1KGzg)
(set to local)
![image](https://private-user-images.githubusercontent.com/20359921/413038744-f12aff2a-46e7-463b-9ee5-13eab7c9b945.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjY2MzMsIm5iZiI6MTczOTY2NjMzMywicGF0aCI6Ii8yMDM1OTkyMS80MTMwMzg3NDQtZjEyYWZmMmEtNDZlNy00NjNiLTllZTUtMTNlYWI3YzliOTQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAwMzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzMDIxZjVhYTc0M2MzY2RlNWEwNGRmYmU3M2E4Y2ViOTMyZDE1ODk1NGUwZDJhNDYxODM1YTZhNTVkMzljMmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.g7FeJxNXhK7Ot4hc451xXiOWTArHIyk2jwx6MT1s81Q)
Fixes #5373
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):